Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update example app #827

Merged
merged 63 commits into from
Mar 23, 2021
Merged

Conversation

kacperkapusciak
Copy link
Member

@kacperkapusciak kacperkapusciak commented Feb 22, 2021

Description

Example app was sidelined for a long time and it needed a major overhaul.

Changes

  • Updated dependencies
  • Added Typescript
  • Rewritten examples with modern 16.8+ React syntax
  • Added interactive playgrounds

Screenshot 2021-03-02 at 12 40 45

Video of one of the playgrounds:

Screen.Recording.2021-03-02.at.12.44.04.mov

Test code and steps to reproduce

cd Example/
yarn                              # install required packages
cd ios/ && pod install  && cd ..  # install pods
yarn start                        # start metro and leave it running

# open new terminal window
cd Example/
npx react-native run-ios      # start iOS simulator
npx react-native run-android  # start Android emulator

Checklist

  • Included code example that can be used to test this change
  • Ensured that CI passes

@kacperkapusciak kacperkapusciak marked this pull request as ready for review March 2, 2021 11:49
Example/ios/Podfile Outdated Show resolved Hide resolved
Example/ios/Podfile Outdated Show resolved Hide resolved
Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better and better every time! I spotted some problems:

Example/src/screens/HeaderOptions.tsx Show resolved Hide resolved
Example/src/screens/StackPresentation.tsx Outdated Show resolved Hide resolved
Example/App.tsx Outdated Show resolved Hide resolved
Example/App.tsx Outdated Show resolved Hide resolved
@kacperkapusciak kacperkapusciak merged commit d725393 into master Mar 23, 2021
@kacperkapusciak kacperkapusciak deleted the @kacperkapusciak/update-example-app branch March 23, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants