Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update reference to utf8 encoding #292

Open
j6carey opened this issue Feb 15, 2021 · 1 comment
Open

Update reference to utf8 encoding #292

j6carey opened this issue Feb 15, 2021 · 1 comment
Labels
regression in 0.18 Regresssion that first appeared in 0.18

Comments

@j6carey
Copy link

j6carey commented Feb 15, 2021

In ghci-wrapper/src/Language/Haskell/GhciWrapper.hs does it make sense to replace references to GHC.IO.Handle.utf8 (which seems not to exist in recent versions of base) with GHC.IO.Encoding.utf8?
andreasabel referenced this issue Feb 27, 2021
@quasicomputational
Qualify stdout/stderr references and handle operations.
e184a15 
Fixes #201.
@andreasabel andreasabel added the regression in 0.18 Regresssion that first appeared in 0.18 label Feb 27, 2021
@andreasabel
Copy link
Collaborator

andreasabel commented Feb 27, 2021 •
edited
Loading

This might be a typo, see e184a15#r47636599.
@j6carey, do you have a test case?

andreasabel added a commit to andreasabel/doctest that referenced this issue Feb 27, 2021
@andreasabel
Re sol#292: GHC.IO.Handle.utf8 --> GHC.IO.Encoding.utf8
884e67a 
Was possibly a regression in 0.18.
We do not seem to cover this by the test-suite.
@andreasabel andreasabel mentioned this issue Feb 27, 2021
Closed
@andreasabel andreasabel linked a pull request Feb 27, 2021 that will close this issue
Re #292: GHC.IO.Handle.utf8 --> GHC.IO.Encoding.utf8 #296
Closed
sol pushed a commit that referenced this issue Nov 13, 2021
@andreasabel @sol
Re #292: GHC.IO.Handle.utf8 --> GHC.IO.Encoding.utf8
b145059 
Was possibly a regression in 0.18.
We do not seem to cover this by the test-suite.
sol pushed a commit that referenced this issue Nov 13, 2021
@andreasabel @sol
Re #292: GHC.IO.Handle.utf8 --> GHC.IO.Encoding.utf8
2b021c1 
Was possibly a regression in 0.18.
We do not seem to cover this by the test-suite.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression in 0.18 Regresssion that first appeared in 0.18
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re #292: GHC.IO.Handle.utf8 --> GHC.IO.Encoding.utf8 andreasabel/doctest
2 participants
@andreasabel @j6carey