ci: remove unstable options for stable tests #33103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we'll be uploading artifacts for channel branches now, right? probably not a problem so long as buildkite doesn't have some absurdly small artifact storage limits |
|
yeah. we upload test results for channel branches. will try to resume it asap |
got it. yeah seems like having that helper that resolves whether to do the upload or not return the prefix command(s) directly would work just as well at normalizing the cargo instantiation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
-Zunstable-optionscan't be used since 1.70.0 (https://blog.rust-lang.org/2023/06/01/Rust-1.70.0.html#enforced-stability-in-the-test-cli) upstream tracking issue: rust-lang/rust#49359a possible solution,
--timings=json, is still unstable atm 😢Summary of Changes
remove unstable options for stable tests atm. we will lose some test report. For unblocking our master CI, I still would like to have this stopgap first.
I will try to finish #33102 soon!