Skip to content
This repository has been archived by the owner on Apr 13, 2022. It is now read-only.

mark link header discovery as at risk #20

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

elf-pavlik
Copy link
Member

As discussed in #18 (comment)

@dmitrizagidulin
Copy link
Member

👍

1 similar comment
@zenomt
Copy link

zenomt commented Apr 27, 2019

+1

@elf-pavlik
Copy link
Member Author

I understood that @kjetilk currently acts as editor in all spec and merges PRs

@kjetilk
Copy link
Member

kjetilk commented Apr 29, 2019

Yeah, at least we're trying to draw up a process around it so that we can get things done :-)

@michielbdejong
Copy link

@kjetilk I think we have agreement on this one, can you merge this?

@michielbdejong
Copy link

I don't have access to merge this.

@kjetilk kjetilk self-requested a review May 29, 2019 23:28
Copy link
Member

@kjetilk kjetilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that @jvasseur proposed a use case where it could be useful, I think the rest of the comments in #18 makes this PR valid. If there are use cases for it, we can work that out even if it is marked at risk.

@michielbdejong
Copy link

@kjetilk can you merge this?

@kjetilk
Copy link
Member

kjetilk commented Jun 13, 2019

Ah, right. We haven't got the labels that we use in solid-spec here, but I think it has had sufficient review time.

@kjetilk kjetilk merged commit 2b2c5a3 into solid:master Jun 13, 2019
@elf-pavlik elf-pavlik deleted the link-header-at-risk branch June 14, 2019 00:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants