Improve signal setter type for code completion of string literal unio…

…ns. (#2297) * fix * fix test * Create shy-islands-talk.md --------- Co-authored-by: Ryan Carniato <ryansolid@gmail.com>
solidjs · Sep 24, 2024 · 80b0958 · 80b0958
1 parent 4f8597d
commit 80b0958
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/shy-islands-talk.md b/.changeset/shy-islands-talk.md
@@ -0,0 +1,5 @@
+---
+"solid-js": patch
+---
+
+Improve signal setter type for code completion of string literal unions.
diff --git a/packages/solid/src/reactive/signal.ts b/packages/solid/src/reactive/signal.ts
@@ -179,12 +179,12 @@ export function createRoot<T>(fn: RootFunction<T>, detachedOwner?: typeof Owner)
 export type Accessor<T> = () => T;
 
 export type Setter<in out T> = {
+  <U extends T>(value: Exclude<U, Function> | ((prev: T) => U)): U;
   <U extends T>(...args: undefined extends T ? [] : [value: (prev: T) => U]): undefined extends T
     ? undefined
     : U;
-  <U extends T>(value: (prev: T) => U): U;
   <U extends T>(value: Exclude<U, Function>): U;
-  <U extends T>(value: Exclude<U, Function> | ((prev: T) => U)): U;
+  <U extends T>(value: (prev: T) => U): U;
 };
 
 export type Signal<T> = [get: Accessor<T>, set: Setter<T>];