Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove vitest globals types from base tsconfig #2237

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

Gpx
Copy link
Contributor

@Gpx Gpx commented Jul 25, 2024

Summary

The tsconfig.json file includes types for vitest/globals. Those types are already included in tsconfig.test.json which makes them available in test files. If we include the types in tsconfig.json we make them available in all files.

This is, for example, what happens in packages/solid/src/index.ts:

Screenshot 2024-07-25 at 16 48 47

After this change a TypeScript error is shown instead:

Screenshot 2024-07-25 at 16 49 04

How did you test this change?

I run pnpm run build && pnpm run test && pnpm run types.
This is my first PR to this project so please let me know if I missed something.

Copy link

changeset-bot bot commented Jul 25, 2024

⚠️ No Changeset found

Latest commit: ff572fa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10096496616

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.37%

Totals Coverage Status
Change from base Build 10085144700: 0.0%
Covered Lines: 4193
Relevant Lines: 4427

💛 - Coveralls

@ryansolid ryansolid merged commit 61dd1e8 into solidjs:main Jul 25, 2024
1 check passed
@ryansolid
Copy link
Member

Thanks

@Gpx Gpx deleted the improve_ts_config branch July 26, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants