Tax fix for finalized adjustments v2 #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise taxes don't get updated after an order completes (because all adjustments are finalized when an order completes).
jordan-brough
force-pushed
the
tax-fix-for-finalized-adjustments-v2
branch
from
0566f32
to
6506550
Compare
jordan-brough
force-pushed
the
tax-fix-for-finalized-adjustments-v2
branch
from
062241c
to
22c96e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #1917. Fixes #1916. Also related to #1894 and #1892.
Ignore adjustment.finalized on Tax adjustments
Otherwise taxes don't get updated after an order completes (because all
adjustments are finalized when an order completes).