Inja transformation preserve escaped json #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbohanon
commented
Jul 20, 2023
api/envoy/config/filter/http/transformation/v2/transformation_filter.proto
Outdated
Show resolved
Hide resolved
|
Issues linked to changelog: |
kdorosh
reviewed
Jul 21, 2023
Comment on lines
259
to
261
| // Use to render the output of a body transformation as JSON. This will cause | ||
| // rendered string values to be escaped in order to make valid JSON strings | ||
| bool render_body_as_json = 12; |
There was a problem hiding this comment.
i think we should rename this. perhaps this has similar utility for folks who want the body rendered for, say, yaml
There was a problem hiding this comment.
I like it. I renamed the field
nfuden
reviewed
Jul 21, 2023
kdorosh
reviewed
Jul 21, 2023
kdorosh
reviewed
Jul 21, 2023
add comments; rename new proto field; add tests for nested json
kdorosh
reviewed
Jul 21, 2023
Comment on lines
+356
to
+361
| // make sure to bail if we're not working with a raw string value | ||
| if(!input->is_string()) { | ||
| return input->get_ref<const std::string&>(); | ||
| } | ||
|
|
||
| auto val = input->dump(); |
kdorosh
approved these changes
Jul 21, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users have the issue that when they transform a request or response body that includes escaped characters, for example this json request/response body
{ "foo": "{\"bar\":\"baz\"}" }The characters lose their escaping when used in a template e.g. the template
{"response":"{{ foo }}"}would produce the string{"response":"{"bar":"baz"}"}which is not valid JSON since the quotes are not escaped. Instead we expect to be able to produce
{"response":"{\"bar\":\"baz\"}"}This PR provides 2 methods of achieving this
raw_stringcan be used to escape a particular value within a template.{"response":"{{ raw_string(foo) }}"}escape_characterson theTransformationTemplatesetting