Admin endpoint: return more resources #9766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… admin-endpoint-flatten
jenshu
added
the
work in progress
github-actions
bot
added
the
keep pr updated
4 tasks
|
Visit the preview URL for this PR (updated for commit 702820a): https://gloo-edge--pr9766-admin-endpoint-more-21b1wfym.web.app (expires Wed, 24 Jul 2024 01:33:55 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
|
Issues linked to changelog: |
jenshu
removed
the
work in progress
jbohanon
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
This is awesome! 🚀
I think there is some opportunity for serving a specific resource type on /snapshots/input/{kind} or /snapshots/input/{groupkind} but even just with jq magic, this is so useful e.g.
curl -s localhost:9091/snapshots/input | jq '.[] | select(.kind=="GatewayParameters" or .kind=="RouteOption" or .kind=="Settings") | .kind, .spec, .status'
sam-heilbron
approved these changes
Jul 17, 2024
jenshu
added a commit
that referenced
this pull request
Jul 19, 2024
* add convert code * make getRedactedApiSnapshot private * flatten kube resources * rename client * fix tests * changelog * add comments and test * return more resources * refactor gvks check * refactor numfields check * changelog * add more tests --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
soloio-bulldozer bot
added a commit
that referenced
this pull request
Jul 19, 2024
* Flatten resources returned by Admin endpoint (#9760) * add convert code * make getRedactedApiSnapshot private * flatten kube resources * rename client * fix tests * changelog * add comments and test * refactor gvks check * refactor numfields check --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> * Admin endpoint: return more resources (#9766) * add convert code * make getRedactedApiSnapshot private * flatten kube resources * rename client * fix tests * changelog * add comments and test * return more resources * refactor gvks check * refactor numfields check * changelog * add more tests --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> * Admin endpoint: allow overriding kube gateway gvks (#9716) * extensions startfuncs * add convert code * make getRedactedApiSnapshot private * flatten kube resources * rename client * fix tests * changelog * add comments and test * return more resources * refactor gvks check * refactor numfields check * updates * set gvks * pass history as param * sort proxies too * remove the startfuncs stuff * changelog * add more tests * update api * changelog * add tests * refactor sort * Adding changelog file to new location * Deleting changelog file from old location * refactor * fix tests * fix compile * empty * add SnapshotHistoryFactory to validation --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: changelog-bot <changelog-bot> * consolidate changelogs --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part 2 of updates to admin server input snapshot endpoint:
Checklist: