admin/history: fast-follow PR feedback #9856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
keep pr updated
sam-heilbron
removed
the
work in progress
npolshakova
approved these changes
Aug 2, 2024
|
Visit the preview URL for this PR (updated for commit ed746ff): https://gloo-edge--pr9856-sh-admin-server-p4-mal0058g.web.app (expires Fri, 09 Aug 2024 20:57:19 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
jenshu
approved these changes
Aug 2, 2024
Co-authored-by: Jenny Shu <28537278+jenshu@users.noreply.github.com>
jenshu
approved these changes
Aug 2, 2024
sam-heilbron
added a commit
that referenced
this pull request
Aug 16, 2024
* fast follow to previous pr * add changelog * Update projects/gloo/pkg/servers/iosnapshot/resources.go Co-authored-by: Jenny Shu <28537278+jenshu@users.noreply.github.com> --------- Co-authored-by: Jenny Shu <28537278+jenshu@users.noreply.github.com> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
5 tasks
sam-heilbron
added a commit
that referenced
this pull request
Aug 16, 2024
* admin/history: expand implementation and tests (#9797) * tests for asserting resources returned by snpashot endpoint * flush out tests * goimports * add changelog * skip kube tests * add comments to exported functions * Adding changelog file to new location * Deleting changelog file from old location * incorporate PR feedback * deprecate dev_mode * add changelog * move changelog * working history tests * resouces -> resourceList * unfocus history_test * update issue refernces, goimports * docs around adminserver and devMode * update changelog * Sh/remove history managed fields part2 (#9820) * add changelog * redact secret and artifact data, add tests * handle errors * conslidate changelog * update docs to reflect reponse shape * goimports * output data as string, not bytes * update terminology in docs * use getter * fix tests for type change * use getter * simplify handling of response status, use constants * update tests * introduce tests for custom_resource * more enhanced tests to getEdgeApiSnapshot * marshal data properly * update comment * make test assertion more expliicit * update lint action, goimports * tests to show upstreams and secrets repseect kube api server over api snapshot * Adding changelog file to new location * Deleting changelog file from old location * support secrest and upstreams correctly * use getter * fix custom_resource_test.go * use constants for output format * move secret GVK * format output correctly * fix nil checks --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: changelog-bot <changelog-bot> Co-authored-by: Jenny Shu <jenny.shu@solo.io> * admin/history: Return redacted Artifacts and Secrets in InputSnapshot (#9844) * tests for asserting resources returned by snpashot endpoint * flush out tests * goimports * add changelog * skip kube tests * add comments to exported functions * Adding changelog file to new location * Deleting changelog file from old location * incorporate PR feedback * deprecate dev_mode * add changelog * move changelog * working history tests * resouces -> resourceList * unfocus history_test * update issue refernces, goimports * docs around adminserver and devMode * update changelog * Sh/remove history managed fields part2 (#9820) * add changelog * redact secret and artifact data, add tests * handle errors * conslidate changelog * update docs to reflect reponse shape * goimports * output data as string, not bytes * update terminology in docs * use getter * fix tests for type change * use getter * simplify handling of response status, use constants * update tests * introduce tests for custom_resource * more enhanced tests to getEdgeApiSnapshot * marshal data properly * update comment * make test assertion more expliicit * update lint action, goimports * tests to show upstreams and secrets repseect kube api server over api snapshot * Adding changelog file to new location * Deleting changelog file from old location * support secrest and upstreams correctly * use getter * fix custom_resource_test.go * use constants for output format * move secret GVK * format output correctly * WIP * code complete-ish, working on tests now * removeoutput * fix NewHIstory tests * WIP * conslidate schemes * re-add assertion that was removed by accident * passing tests * fixup history_test * add changelog * introduce tests for admin server * fix e2e test * document admin api * fixup comment * fix gloo client tests * Fixup gloo admin client tests * use .String() method where possible * add tests for edge and k8s gw apis * stronger assertions, do not register schemes in init * use newScheme --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: changelog-bot <changelog-bot> * admin/history: fast-follow PR feedback (#9856) * fast follow to previous pr * add changelog * Update projects/gloo/pkg/servers/iosnapshot/resources.go Co-authored-by: Jenny Shu <28537278+jenshu@users.noreply.github.com> --------- Co-authored-by: Jenny Shu <28537278+jenshu@users.noreply.github.com> Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> * move changelog * fixup changelog, imports --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Jenny Shu <jenny.shu@solo.io> Co-authored-by: Jenny Shu <28537278+jenshu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fast follow changes to incorporate feedback from #9844
Context
The previous conversations can be found here:
Interesting decisions
Testing steps
These are not functional changes, so I relied on the existing CI tests to validate
Notes for reviewers
Checklist: