Ensure namespace override consistency #9888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
keep pr updated
|
Visit the preview URL for this PR (updated for commit 0db052b): https://gloo-edge--pr9888-jbohanon-test-summar-o7b8iq9q.web.app (expires Wed, 21 Aug 2024 15:25:40 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
jbohanon
changed the title
sam-heilbron
approved these changes
Aug 13, 2024
npolshakova
reviewed
Aug 13, 2024
|
Nightly action kicked off here to test https://github.com/solo-io/gloo/actions/runs/10376999685 |
.github/workflows/composite-actions/kubernetes-e2e-tests/action.yaml
Outdated
Show resolved
Hide resolved
jbohanon
changed the title
sam-heilbron
approved these changes
Aug 14, 2024
jbohanon
removed
the
work in progress
npolshakova
approved these changes
Aug 14, 2024
jbohanon
added a commit
that referenced
this pull request
Aug 15, 2024
* update to test structure * add consistency to namespace handling in test setup * remove ref to env pkg * move kuberentes e2e test util tests to gha unit tests * update timeout for nightlies * add check to action for tests all being run under TestGlooGateway * add namespace code to example test * fix regex * remove summaries change * update changelog --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
soloio-bulldozer bot
added a commit
that referenced
this pull request
Aug 15, 2024
* Ensure namespace override consistency (#9888) * update to test structure * add consistency to namespace handling in test setup * remove ref to env pkg * move kuberentes e2e test util tests to gha unit tests * update timeout for nightlies * add check to action for tests all being run under TestGlooGateway * add namespace code to example test * fix regex * remove summaries change * update changelog --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> * bring util test over * make IsEnvTruthy use IsTruthyValue --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Namespace pollution
Currently we have some tests which rely on programmatically setting the
INSTALL_NAMESPACEenv var. This was introduced to be able to expand that var into various resource manifests for edge routing resources. The application of this logic was introduced inconsistently across all of the different test installation suites we currently run, and was causing flakes due to ordering if not cleaned up properly. This PR applies the same logic to all test installation suites (except upgrade which is a special case) and makes sure we clean up after ourselves if we set the env var.Test utils unit tests
Test utils unit tests at
test/kubernetes/testutils/helperhave been migrated to run on a GHA in lieu of in cloudbuild since they require an authorized github token. This is to unblock community PRs coming in from forks of the repo.Nightlies timeout update
We recently hit a failure in our nightly tests due to a GHA timeout. In this PR we bump the timeout to 120 minutes for the go test command and 150 minutes for the overall action.