[1.17] fix: allows setting Istio CA_ADDR independently #9897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: allows setting Istio CA_ADDR independently https://istio.io/latest/docs/reference/commands/pilot-agent/ The Istio documentation indicates that CA_ADDR defaults to the PROXY_CONFIG discovery address. Though it should be possible to specify a CA_ADDR that is unrelated to the discovery address. However, Gloo helm forces these two separate fields to be aligned as it is driven from a single helm value. This change introduces an `istioSpiffeCertProviderAddress` property resolving the problem. The default is kept as `istioDiscoveryAddress` to ensure backward compatibility. * docs: add property documentation + issue link * move changelog to beta15 folder * helm_test: fix compile issues, resolve some deprecated function calls --------- Co-authored-by: Sam Heilbron <samheilbron@gmail.com>
|
Issues linked to changelog: |
github-actions
bot
added
the
keep pr updated
npolshakova
approved these changes
Aug 14, 2024
ashishb-solo
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://istio.io/latest/docs/reference/commands/pilot-agent/
The Istio documentation indicates that CA_ADDR defaults to the PROXY_CONFIG discovery address. Though it should be possible to specify a CA_ADDR that is unrelated to the discovery address.
However, Gloo helm forces these two separate fields to be aligned as it is driven from a single helm value.
This change introduces an
istioSpiffeCertProviderAddressproperty resolving the problem. The default is kept asistioDiscoveryAddressto ensure backward compatibility.Context
Backport of: #9756
Interesting decisions
Testing steps
Notes for reviewers
Checklist: