require not replace #464
Closed
require not replace #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As was done in solo-io/gloo, we should be using exclude directives that mirror the deprecate functionality in go1.18. This block has been borrowed wholesale from that repo. As well, now instead of replacing k8s.io/client-go with the version that we actually want, we can just require it. Other requires have been left unmodified. Updates solo-io#461.
|
Waiting for approval from someone in the solo-io org to start testing. |
colin-arnott-xero
added a commit
to colin-arnott-xero/solo-apis
that referenced
this pull request
Jun 22, 2022
This change is a spiritual backport of solo-io#464. However since excludes have already been dropped here, we can just require the version of k8s.io/client-go that we actually want.
colin-arnott-xero
added a commit
to colin-arnott-xero/solo-apis
that referenced
this pull request
Jun 28, 2022
This change is a spiritual backport of solo-io#464. However since excludes have already been dropped here, we can just require the version of k8s.io/client-go that we actually want.
|
@gunnar-solo, do you mind explaining why you closed this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As was done in solo-io/gloo, we should be using exclude directives that
mirror the deprecate functionality in go1.18. This block has been
borrowed wholesale from that repo.
As well, now instead of replacing k8s.io/client-go with the version that
we actually want, we can just require it. Other requires have been left
unmodified.
Updates #461