Config Reload Enhancement #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dgsudharsan can you please add how this works along with ZTP? ZTP might use some of the GNMI services during reload cases. |
@skg-net I don't think it is going to affect ZTP. In the ZTP too, there will be swss initialization, followed by PortInitDone message posted to APP_DB. Once it is received, all the delayed services include telemetry and mgmt-framework should start. Even today they start in a delayed fashion (3m 30 seconds) but with this change, they should be starting soon after port initialization. |
prvattem
reviewed
Jan 10, 2023
prvattem
reviewed
Jan 10, 2023
prvattem
reviewed
Jan 10, 2023
prvattem
reviewed
Jan 10, 2023
prsunny
reviewed
Jan 10, 2023
dgsudharsan
requested review from
prvattem and
prsunny
and removed request for
prvattem
stepanblyschak
approved these changes
Feb 13, 2023
|
@zhangyanzhao this HLD is ready for weeks now and already passed community review. what is next? |
venkatmahalingam
approved these changes
Feb 21, 2023
prvattem
approved these changes
Feb 22, 2023
liat-grozovik
approved these changes
Feb 23, 2023
This was referenced Feb 23, 2023
qiluo-msft
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Apr 11, 2023
…fig reload enhancement (#7558) ### Approach #### What is the motivation for this PR? Modifying config reload tests to align with latest config reload enhancement according to HLD sonic-net/SONiC#1203 #### How did you do it? Removed the timer based checks #### How did you verify/test it? Run the tests with config reload enhamcenet changes
qiluo-msft
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Apr 11, 2023
#### What I did Code changes for HLD: sonic-net/SONiC#1203 Removed the timer based checks for config reload Added db_migrator to migrate from "has_timer" to "delayed" Modified package-manager to migrate from "has_timer" to "delayed" #### How I did it Modified relevant files #### How to verify it Added UT to verify
qiluo-msft
pushed a commit
to sonic-net/sonic-host-services
that referenced
this pull request
Apr 11, 2023
Code changes for config reload Enhancement sonic-net/SONiC#1203. Enhancing config reload to sequence the services and faster system initialization. Immediately restart the critical services during config reload. The non critical should be started only after all the ports are initialized. Services can be configured to be started immediately or delayed. This can be using a field in FEATURE table. The existing timers should be removed by this event driven approach. This flow is applicable in case of all reboots (warm/fast/cold) as well as config reload.
qiluo-msft
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Apr 12, 2023
#### Why I did it Implementing code changes for sonic-net/SONiC#1203 #### How I did it Removed the timers and delayed target since the delayed services would start based on event driven approach. Cleared port table during config reload and cold reboot scenario. Modified yang model, init_cfg.json to change has_timer to delayed #### How to verify it Running regression
6 tasks
keboliu
pushed a commit
to keboliu/sonic-host-services
that referenced
this pull request
Apr 17, 2023
Code changes for config reload Enhancement sonic-net/SONiC#1203. Enhancing config reload to sequence the services and faster system initialization. Immediately restart the critical services during config reload. The non critical should be started only after all the ports are initialized. Services can be configured to be started immediately or delayed. This can be using a field in FEATURE table. The existing timers should be removed by this event driven approach. This flow is applicable in case of all reboots (warm/fast/cold) as well as config reload. Conflicts: tests/hostcfgd/hostcfgd_test.py tests/hostcfgd/test_vectors.py
dgsudharsan
added a commit
to dgsudharsan/sonic-utilities
that referenced
this pull request
May 26, 2023
Code changes for HLD: sonic-net/SONiC#1203 Removed the timer based checks for config reload Added db_migrator to migrate from "has_timer" to "delayed" Modified package-manager to migrate from "has_timer" to "delayed" Modified relevant files Added UT to verify
dgsudharsan
added a commit
to dgsudharsan/sonic-host-services
that referenced
this pull request
May 26, 2023
Code changes for config reload Enhancement sonic-net/SONiC#1203. Enhancing config reload to sequence the services and faster system initialization. Immediately restart the critical services during config reload. The non critical should be started only after all the ports are initialized. Services can be configured to be started immediately or delayed. This can be using a field in FEATURE table. The existing timers should be removed by this event driven approach. This flow is applicable in case of all reboots (warm/fast/cold) as well as config reload.
dgsudharsan
added a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
May 26, 2023
Implementing code changes for sonic-net/SONiC#1203 Removed the timers and delayed target since the delayed services would start based on event driven approach. Cleared port table during config reload and cold reboot scenario. Modified yang model, init_cfg.json to change has_timer to delayed Running regression
StormLiangMS
pushed a commit
to sonic-net/sonic-host-services
that referenced
this pull request
Jun 10, 2023
Backporting #45 Code changes for config reload Enhancement sonic-net/SONiC#1203. Enhancing config reload to sequence the services and faster system initialization. Immediately restart the critical services during config reload. The non critical should be started only after all the ports are initialized. Services can be configured to be started immediately or delayed. This can be using a field in FEATURE table. The existing timers should be removed by this event driven approach. This flow is applicable in case of all reboots (warm/fast/cold) as well as config reload.
StormLiangMS
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Jun 10, 2023
Backporting #2693 What I did Code changes for HLD: sonic-net/SONiC#1203 Removed the timer based checks for config reload Added db_migrator to migrate from "has_timer" to "delayed" Modified package-manager to migrate from "has_timer" to "delayed" How I did it Modified relevant files How to verify it Added UT to verify
dgsudharsan
added a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
Jun 10, 2023
Implementing code changes for sonic-net/SONiC#1203 Removed the timers and delayed target since the delayed services would start based on event driven approach. Cleared port table during config reload and cold reboot scenario. Modified yang model, init_cfg.json to change has_timer to delayed Running regression
StormLiangMS
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jun 12, 2023
Backporting #13969 Why I did it Implementing code changes for sonic-net/SONiC#1203 Work item tracking Microsoft ADO (number only): How I did it Removed the timers and delayed target since the delayed services would start based on event driven approach. Cleared port table during config reload and cold reboot scenario. Modified yang model, init_cfg.json to change has_timer to delayed How to verify it Added UT to verify
|
@dgsudharsan Can you please update the Quality Metric (Alpha/Beta/GA) for the feature either in this PR comments or in HLD itself based on https://github.com/sonic-net/SONiC/blob/master/doc/SONiC%20feature%20quality%20definition.md |
qiluo-msft
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Sep 15, 2024
Config Reload Enhancements PR sonic-net/SONiC#1203 does not completely remove TIMERs from SONiC Package Manager infra. This PR is intended to complete the original changes. `Systemd` TIMERs infra was replaced by `hostcfgd` service management. That was done to improve reliability of service management. #### What I did * Removed redundant TIMERs infra #### How I did it * Updated SPM auto generation logic #### How to verify it 1. Install application extension ```bash spm install --from-tarball <app_ext_path> ``` 2. Make sure `delayed` flag is set ```bash docker image inspect <app_ext_image> | jq '.[].Config.Labels["com.azure.sonic.manifest"]' | python -c 'import sys,ast; print(ast.literal_eval(sys.stdin.read()))' | jq .service.delayed true ``` 3. Check no TIMERs were generated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design to address the issue sonic-net/sonic-buildimage#12071
Enhancing config reload to sequence the services and faster system initialization.