Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonic Netconf Server Proposal #1466

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

aseaudi
Copy link

@aseaudi aseaudi commented Sep 9, 2023

This PR is for an update in the Sonic Management Framework to add an RFC Compliant Netconf Server, which reuses the Translib and the yang models that are already part of the management framework.

The updated management framework HLD that includes the Netconf Server is under /doc/mgmt/Management Framework.md

@a-barboza
Copy link
Collaborator

I believe there is another proposal going on for NetCONF server support in SONiC:

#1428

@ebiken-ntt
Copy link
Contributor

I believe there is another proposal going on for NetCONF server support in SONiC:
#1428

Yes. We have discussed our (NTT's) NETCONF HLD #1428 in today's SONiC UMF working group meeting.
You can find the recording here: https://github.com/sonic-net/SONiC/wiki/Working-Group-and-Weekly-Meeting-Recordings-Links

We would also like @aseaudi to share this #1466 proposal to the UMF WG community. (Ritu or someone from the WG should contact you to join the WG meeting)

@zhangyanzhao
Copy link
Collaborator

BRCM registered as reviewer.
SONiC community review recording https://zoom.us/rec/share/aweG3ImuMEJXmjU3m4d5DjE3mRGV_cWzLFJtzGvfq_ZxsMAJ9KNqVPgRw45GZDgE.17WdOQVPU5MnopRz

@zhangyanzhao zhangyanzhao requested review from kwangsuk and removed request for kwangsuk September 28, 2023 17:49
@jeff-yin
Copy link

@zhangyanzhao please add @prvattem, @rathnasabapathyv, @mhampasagar, @joyas-joseph as reviewers from Dell.

@adyeung
Copy link
Collaborator

adyeung commented Sep 28, 2023

Adding @anand-kumar-subramanian @a-barboza @mbalachandar @sachinholla @faraazbrcm to review and share comments

@zhangyanzhao
Copy link
Collaborator

@zhangyanzhao please add @prvattem, @rathnasabapathyv, @mhampasagar, @joyas-joseph as reviewers from Dell.

added except mhampassagar who needs to accept the invitation to become a reviewer.

@zhangyanzhao
Copy link
Collaborator

sachinholla

invitation is sent out, will add them after accepting the invitation

@kwangsuk
Copy link

Can you please add the NETCONF server capabilities supported by the proposal?

Copy link
Contributor

@anand-kumar-subramanian anand-kumar-subramanian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need more information on the Netconf server similar to the sections 3.2.2.5 gNMI server and 4.4 gNMI flow.

@@ -174,30 +175,37 @@ Management framework is a SONiC application which is responsible for providing v
1. Standard [YANG](https://tools.ietf.org/html/rfc7950) models (e.g. OpenConfig, IETF, IEEE)
2. Custom YANG models ([SONiC YANG](https://github.com/sonic-net/SONiC/blob/master/doc/mgmt/SONiC_YANG_Model_Guidelines.md))
3. Industry-standard CLI / Cisco like CLI

* Must provide support for [OpenAPI spec](http://spec.openapis.org/oas/v3.0.3) to generate REST server side code
* Must provide support for [OpenAPI spec](http://spec.openapis.org/oas/v3.0.3) to generate REST server side code and NETCONF server side code
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is OpenAPI spec going to be used to generate NETCONF server side code?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be REST only, we removed NETCONF part

@zhangyanzhao
Copy link
Collaborator

@aseaudi can you please help to add the code PRs to this HLD by referring to #806 ? Thanks.

@aseaudi
Copy link
Author

aseaudi commented Oct 13, 2023

@kwangsuk

Can you please add the NETCONF server capabilities supported by the proposal?

Done

@aseaudi
Copy link
Author

aseaudi commented Oct 13, 2023

resolves #1498

@zhangyanzhao
Copy link
Collaborator

@aseaudi can you please help to add the code PRs by referring to #806 ? Thanks.

@zhangyanzhao
Copy link
Collaborator

code PR is not ready, move to backlog for future release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: DeferredForNextRelease
Status: MovedToBacklog
Development

Successfully merging this pull request may close these issues.

8 participants