Minpoll maxpoll doc update #1478
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 19, 2023
jeff-yin
requested review from
fastiuk,
zhangyanzhao,
yxieca and
saiarcot895
fastiuk
reviewed
Nov 19, 2023
doc/ntp/ntp-design.md
Outdated
| @@ -28,6 +28,7 @@ | |||
| | Rev | Date | Author | Description | | |||
| |:---:|:----------:|:-----------------:|:----------------| | |||
| | 0.1 | 01/02/2023 | Yevhen Fastiuk 🇺🇦 | Initial version | | |||
| | 0.1 | 09/18/2023 | Bing Sun | Add NTP server minpoll and maxpoll | | |||
doc/ntp/ntp-design.md
Outdated
Comment on lines
72
to
73
| | minpoll | minimum poll interval | | ||
| | maxpoll | maximum poll interval | |
There was a problem hiding this comment.
minimum -> Minimum
maximum -> Maximum
doc/ntp/ntp-design.md
Outdated
| @@ -189,6 +193,8 @@ Addresses are classed by type as (s) a remote server or peer (IPv4 class A, B an | |||
| | key (ntpd) | none | All packets sent to and received from the server or peer are to include authentication fields encrypted using the specified key identifier with values from 1 to 65535, inclusive. The default is to include no encryption field. | | |||
| | version | 4 | Specifies the version number to be used for outgoing NTP packets. Versions 1-4 are the choices, with version 4 the default. | | |||
| | iburst | none | When the server is unreachable, send a burst of eight packets instead of the usual one. The packet spacing is normally 2 s; however, the spacing between the first two packets can be changed with the calldelay command to allow additional time for a modem or ISDN call to complete. This is designed to speed the initial synchronization acquisition with the server command and s addresses and when ntpd is started with the -q option. | | |||
| | minpoll | 6 | | | |||
There was a problem hiding this comment.
Add some description for minpoll, even it is similar as maxpoll
doc/ntp/ntp-design.md
Outdated
Comment on lines
1095
to
1096
| must "(current()/../maxpoll > current())" { | ||
| error-message "maxpoll has to be larger than minpoll."; |
There was a problem hiding this comment.
Yes. They can be the same. Modified the doc.
doc/ntp/ntp-design.md
Outdated
Comment on lines
1109
to
1110
| must "(current()/../minpoll < current())" { | ||
| error-message "maxpoll has to be larger than minpoll."; |
|
Looks good, just a couple of small comments |
|
@bsun-sudo looks good to me, please address the outstanding comments. |
|
All comments addressed. |
fastiuk
approved these changes
Nov 27, 2023
venkatmahalingam
approved these changes
Nov 28, 2023
|
@bsun-sudo can you please help to add the code PR by referring to #806 ? Thanks. |
|
@bsun-sudo has this HLD been reviewed in community meeting? I can not find a record on my side. Thanks. |
|
code PR is not ready, move to backlog for future release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update is to add support of per NTP server minpoll and maxpoll configuration.