Multiple Spanning Tree Protocol (MSTP) Updated HLD #1761

ridahanif96 · 2024-07-24T04:50:03Z

This document describes the design for Multiple Spanning Tree Protocol (MSTP) support in SONiC.

Previous MSTP Design will no longer be considered. The design is modified with a collaborative efforts of BRCM & xFlow Research to provide MSTP design for Community.

adyeung · 2024-08-02T00:16:48Z

@praveenraja1 @sutharsansr @balajib-cisco @rck-innovium @jeff-yin please review

sutharsansr · 2024-08-18T15:16:19Z

doc/MSTP/MSTP.md

+
+
+## Uplink Fast
+MSTP standard does not support uplink fast so uplink fast functionality will be disable for MSTP.


does this mean HLD is not supporting uplink fast?

UplinkFast was developed by Cisco as an enhancement for classic STP. Since MSTP is an IEEE standard and incorporates RSTP's rapid convergence capabilities, there was no need to include or replicate the UplinkFast feature in MSTP. So this HLD wont support uplink fast.

sutharsansr · 2024-08-18T15:17:45Z

doc/MSTP/MSTP.md

+  - Configure an interface for MSTP.
+
+
+- **config spanning_tree interface \<ifname\> edgeport {enable|disable}**


Does this correspond to AdminEdge Functionality? Will there be a seperate command to support autoEdge?

This correspond to AdminEdge. autoEdge will not be supported.

sutharsansr · 2024-08-18T15:18:34Z

doc/MSTP/MSTP.md

+  - Specify configuring the port level priority for root bridge in seconds.
+  - Default: 128, range 0-240  
+
+- **config spanning_tree interface \<ifname\> cost \<cost-value\>**


should we add a command to configure the link type? P2P/Shared Lan/Auto?

We will add a command for link type.

sutharsansr · 2024-08-18T15:19:52Z

doc/MSTP/MSTP.md

+
+### Functional Test Cases 
+
+1. Verify CONFIG DB is populated with configured MSTP parameters. 


The numbering seems to be stuck with 1 (in other places too) Is it a problem with the template?

This is the template, numbering are done automatically. if you see preview format it will show the correct format.

sutharsansr · 2024-08-18T15:20:20Z

doc/MSTP/MSTP.md

+
+1. Verify MSTP over LAG. 
+
+1. Verify MSTP over static breakout ports. 


Can we add test-cases for BPDU guard and other functionalities?

Added more test-cases for BPDU guard and other functionalities

bendrapubalareddy · 2024-08-21T06:26:46Z

@praveenraja1 @sutharsansr @balajib-cisco @rck-innovium @jeff-yin @adyeung @ridahanif96 @divyachandralekha

Hello All, I want to update here so that all the implementations are aligned on STP, PVST feature is implemented using existing open PRs on stp, validated and automated based on https://github.com/sonic-net/SONiC/blob/master/doc/stp/SONiC_PVST_HLD.md. The complete PR will be raised soon to integrate into 202411 from CISCO.
Pls reachout to @balajib-cisco or me for any information required on this regard.

adyeung · 2024-08-21T17:18:15Z

@madhupalu please invite @bendrapubalareddy to the next PENS WG meeting to discuss the code PRs plan, we have reached a consensus in the WG earlier this year that the older PRs to be dropped to align with MSTP, to avoid further delay of this feature, we need to make sure the community is coherent with the approach

madhupalu · 2024-08-21T18:44:14Z

@madhupalu please invite @bendrapubalareddy to the next PENS WG meeting to discuss the code PRs plan, we have reached a consensus in the WG earlier this year that the older PRs to be dropped to align with MSTP, to avoid further delay of this feature, we need to make sure the community is coherent with the approach

madhupalu · 2024-08-21T18:48:01Z

@bendrapubalareddy please join us next PENS WG meeting here https://zoom-lfx.platform.linuxfoundation.org/meeting/93042804249?password=179075a6-61fe-448e-b4bc-638ea6b6a7ea

adyeung · 2024-08-21T21:14:38Z

@madhupalu don't think you meant to close this HLD, as it's still under review

madhupalu · 2024-08-21T21:20:53Z

@madhupalu don't think you meant to close this HLD, as it's still under review

@adyeung sure, we never close this HLD until it is being reviewed in bigger community - tuesday!

bendrapubalareddy · 2024-08-22T06:40:01Z

Thank you @adyeung <https://github.com/adyeung> @madhupalu <https://github.com/madhupalu>. I will join . Bala

…

On Thu, Aug 22, 2024 at 12:18 AM Madhu Paluru ***@***.***> wrote: @bendrapubalareddy <https://github.com/bendrapubalareddy> please join us next PENS WG meeting here https://zoom-lfx.platform.linuxfoundation.org/meeting/93042804249?password=179075a6-61fe-448e-b4bc-638ea6b6a7ea — Reply to this email directly, view it on GitHub <#1761 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADKZN6TABQXVM6HXZFX4QX3ZSTOHPAVCNFSM6AAAAABLLVWPXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBSG42DANBWGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

zhangyanzhao · 2024-08-27T15:04:09Z

Community review recording https://zoom.us/rec/share/NeY9bEy76Zk5vtE8bjtVim3fs7rkuVXOUXkqrKBowwFBgLbRc6OyyYxB-Rryv2zk.iz7qR4m3uXRM_Q2d

venkatmahalingam · 2024-08-27T15:32:58Z

doc/MSTP/MSTP.md

+#### STP_MST_INST_TABLE
+```
+;Stores the STP per  MSTI operational details
+key                       = _STP_MST_INST_TABLE:"MST" id  


As discussed in the meeting, remove "_" prefix from the tables.

venkatmahalingam · 2024-08-27T15:34:03Z

doc/MSTP/MSTP.md

+MSTP reduces convergence time compared to STP. When a network topology change occurs, only the affected MSTI needs to reconverge, minimizing the impact on the entire network. 
+
+
+


Mention kernel level changes expected to enable MSTP, if no changes expected and following PVST behavior, mention it accordingly.

We will update the HLD.

prvattem · 2024-08-27T15:43:58Z

doc/MSTP/MSTP.md

+
+#  Sequence Diagrams
+## MSTP global enable
+


Please update the flow diagrams with the details, where the APP_DB changes/updates are done.

Please update the diagram with APP_DB details.

We will update the HLD diagram.

prvattem · 2024-08-27T15:44:56Z

doc/MSTP/MSTP.md

+- debug spanning_tree mst instance \<instance-id\>
+- debug spanning_tree mst bpdu [tx|rx]
+- debug spanning_tree mst event
+- debug spanning_tree mst verbose


can this be combined with "debug spanning_tee mst event" with an additional option as "detail"

Can you please elaborate what specific "detail" needs to be done with additional option?

Minor comment - debug spanning_tree mst event [detail] instead of having a verbose command separately

The below debug commands are existing for PVST and we will reuse the same command for MSTP as well.

debug spanning_tree bpdu [tx|rx]

debug spanning_tree event

debug spanning_tree verbose

The below will be new command added for MSTP

debug spanning_tree mst instance <instance-id>

prvattem · 2024-08-27T15:45:56Z

doc/MSTP/MSTP.md

+                        path "../../../STP_PORT/STP_PORT_LIST/ifname";
+                    }
+                    description
+                        "Reference to Ethernet interface or PortChannel";


rephrase it to "Reference to Ethernet interface or PortChannel in the STP database";

Updated as per suggestion

prvattem · 2024-08-27T15:51:06Z

doc/MSTP/MSTP.md

+            }
+        }
+
+	list _STP_MST_INST_TABLE_LIST {


As discussed in the call please remove "_" before the name of the list.

madhupalu · 2024-08-27T17:34:51Z

doc/MSTP/MSTP.md

+mst_boundary_proto  = BIT                       ; enabled or disabled
+```
+
+#### STP_INST_PORT_FLUSH_TABLE 


Why is STP_INST_PORT_FLUSH_TABLE needed in APP_DB? >> it is an action, shouldn't it be put on the APP DB or not?

In general, Redis-DB is used for communication between dockers in the SONiC architecture.
Are you looking of any alternative approaches to inter-docker communication in SONiC that you're familiar with?

madhupalu · 2024-08-27T17:38:17Z

doc/MSTP/MSTP.md

+
+1. Support protocol operation on static breakout ports 
+
+1. Support protocol operation on Port-channel interfaces 


Is the MSTP HLD supports VS image (no ASIC) ?

prvattem · 2024-08-28T06:01:23Z

doc/MSTP/MSTP.md

+
+![MSTP Architecture](images/MSTPDesign_Archi.drawio.png)
+## STP Container
+STP Container is responsible for actions taken for BPDU rx and BPDU tx. Following are the details for implementation:


Please point me to the stp-container in sonic community code. I couldnt find it.
I see the following PR which is in review state:
sonic-net/sonic-buildimage#3463

SONIC has a repository as stp which holds all these details. Please see below link to repo:
https://github.com/sonic-net/sonic-stp

Iam asking about the docker implementation in the PR sonic-net/sonic-buildimage#3463

https://github.com/sonic-net/sonic-stp -- provide stp implementation. I am looking for the stp docker, which is still in a PR sonic-net/sonic-buildimage#3463

Yes Stp docker is still in above open PR.

If the code is still in a PR, how are we basing our design, which is not present in the code base yet?

As discussed in the PENS meeting , we will be pushing the STP docker PR as well.

praveenraja1 · 2024-09-02T15:28:21Z

doc/MSTP/MSTP.md

+
+```
+;Defines instance and port for which FDB Flush needs to be performed
+key                 = STP_INST_PORT_FLUSH_TABLE:instane:ifname         ; FDB Flush instance id and port


why not just use "FLUSHFDBREQUEST PORT" notification, similar to how CLI fdb clear command handles it?

Can you please share for reference code where it is being used.

Sorry for the delayed response, please refer the below py script.

src/sonic-utilities/scripts/fdbclear:33: self.db.publish('APPL_DB','FLUSHFDBREQUEST', msg)

"FLUSHFDBREQUEST PORT" is also a similar redis-DB operation which STPd does here.

praveenraja1 · 2024-09-02T15:35:48Z

doc/MSTP/MSTP.md

+name           
+state               = "true"                                            
+```
+


Can you please add info on how "BPDU guard" functionality will be done, considering it requires port to go into "err-disabled" mode (link-down)

Will existing LINK/PORT tables in APPL_DB be leveraged or new ones be introduced?

MSTP is going to follow the same approach as the PVST does.

bendrapubalareddy · 2024-09-16T13:21:41Z

Hi, Can you pls share the meeting invite for today PENS WG meeting if there is one scheduled? I could not find it on PENS WG page. Thanks, Bala

…

On Wed, Aug 21, 2024 at 10:48 PM Adam Yeung ***@***.***> wrote: @madhupalu <https://github.com/madhupalu> please invite @bendrapubalareddy <https://github.com/bendrapubalareddy> to the next PENS WG meeting to discuss the code PRs plan, we have reached a consensus in the WG earlier this year that the older PRs to be dropped to align with MSTP, to avoid further delay of this feature, we need to make sure the community is coherent with the approach — Reply to this email directly, view it on GitHub <#1761 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADKZN6VWHWFUCS5TB43ULSDZSTDW7AVCNFSM6AAAAABLLVWPXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBSGU4TCNZYGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

ridahanif96 · 2024-09-16T13:30:59Z

Hi,
Can you pls share the meeting invite for today PENS WG meeting if there is
one scheduled? I could not find it on PENS WG page.

Thanks,
Bala

On Wed, Aug 21, 2024 at 10:48 PM Adam Yeung @.***>
wrote:

@madhupalu https://github.com/madhupalu please invite @bendrapubalareddy
https://github.com/bendrapubalareddy to the next PENS WG meeting to
discuss the code PRs plan, we have reached a consensus in the WG earlier
this year that the older PRs to be dropped to align with MSTP, to avoid
further delay of this feature, we need to make sure the community is
coherent with the approach

—
Reply to this email directly, view it on GitHub
#1761 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADKZN6VWHWFUCS5TB43ULSDZSTDW7AVCNFSM6AAAAABLLVWPXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBSGU4TCNZYGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi Bala,

PENS lab meet is scheduled today.

Please see below meeting joining details

https://zoom-lfx.platform.linuxfoundation.org/meeting/93042804249?password=179075a6-61fe-448e-b4bc-638ea6b6a7ea

Regards

MSTP Updated Design

7e04e84

ridahanif96 mentioned this pull request Jul 24, 2024

Multiple Spanning Tree Protocol (MSTP) HLD #1298

Closed

Slight changes

5d2e373

wajahatrazi and others added 2 commits August 13, 2024 14:45

Merge branch 'sonic-net:master' into MSTP

3e280d2

Updated the Architecture diagram

fe487f8

madhupalu self-requested a review August 16, 2024 20:49

sutharsansr reviewed Aug 18, 2024

View reviewed changes

Added Link-type command

c55a575

madhupalu closed this Aug 21, 2024

adyeung reopened this Aug 21, 2024

ridahanif96 added 4 commits August 23, 2024 16:23

Update MSTP.md

eb1a177

MOdified images

3d71aab

Added Images

580a563

Slight changes

fde7a94

venkatmahalingam reviewed Aug 27, 2024

View reviewed changes

prvattem reviewed Aug 27, 2024

View reviewed changes

madhupalu reviewed Aug 27, 2024

View reviewed changes

prvattem reviewed Aug 28, 2024

View reviewed changes

Changes as per suggestions

94dceaf

praveenraja1 approved these changes Sep 2, 2024

View reviewed changes

ridahanif96 added 2 commits September 26, 2024 08:51

Updated Diagrams

fecd59d

Updated instance deletion sequence

d9868d0



		## Uplink Fast
		MSTP standard does not support uplink fast so uplink fast functionality will be disable for MSTP.

		- Configure an interface for MSTP.


		- config spanning_tree interface \<ifname\> edgeport {enable\|disable}


		### Functional Test Cases

		1. Verify CONFIG DB is populated with configured MSTP parameters.


		1. Verify MSTP over LAG.

		1. Verify MSTP over static breakout ports.

		MSTP reduces convergence time compared to STP. When a network topology change occurs, only the affected MSTI needs to reconverge, minimizing the impact on the entire network.


		1. Support protocol operation on static breakout ports

		1. Support protocol operation on Port-channel interfaces

Multiple Spanning Tree Protocol (MSTP) Updated HLD #1761

Are you sure you want to change the base?

Multiple Spanning Tree Protocol (MSTP) Updated HLD #1761

Conversation

ridahanif96 commented Jul 24, 2024

adyeung commented Aug 2, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bendrapubalareddy commented Aug 21, 2024 • edited Loading

adyeung commented Aug 21, 2024

madhupalu commented Aug 21, 2024

madhupalu commented Aug 21, 2024

adyeung commented Aug 21, 2024 • edited Loading

madhupalu commented Aug 21, 2024

bendrapubalareddy commented Aug 22, 2024 via email

zhangyanzhao commented Aug 27, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prvattem Sep 20, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bendrapubalareddy commented Sep 16, 2024 via email

ridahanif96 commented Sep 16, 2024

adyeung commented Aug 2, 2024 •

edited

Loading

bendrapubalareddy commented Aug 21, 2024 •

edited

Loading

adyeung commented Aug 21, 2024 •

edited

Loading

prvattem Sep 20, 2024 •

edited

Loading