Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[virtual-switch] Port config ini type for portsyncd hardcoded #1990

Closed
NehaRajeM opened this issue Aug 28, 2018 · 7 comments
Closed

[virtual-switch] Port config ini type for portsyncd hardcoded #1990

NehaRajeM opened this issue Aug 28, 2018 · 7 comments
Assignees
Labels

Comments

@NehaRajeM
Copy link

port_config.ini hardcoded for Force10 routers in supervisord.conf for virtual switch.
https://github.com/Azure/sonic-buildimage/blob/master/platform/vs/docker-sonic-vs/supervisord.conf

[program:portsyncd]
command=/usr/bin/portsyncd -p /usr/share/sonic/device/x86_64-dell_s6000_s1220-r0/Force10-S6000/port_config.ini
priority=6
autostart=false
autorestart=false
stdout_logfile=syslog
stderr_logfile=syslog

Expected: based on the hwsku/platform set, the appropriate port_config.ini should be selected.

@stcheng
Copy link
Contributor

stcheng commented Aug 28, 2018

this leads to another issue that when executing show platform summary the output will be empty. It is better to have the platform set as virtual switch and have a specific config_config.ini file for this platform.

@lguohan
Copy link
Collaborator

lguohan commented Aug 28, 2018

@taoyl-ms currently vs can only support Force10-S6000 port_config ini. as long as the vs has 32 ports, we do not need to change that.

What is the issue you are facing?

@NehaRajeM
Copy link
Author

So you mean to say that vs cannot support Arista devices as of now?
I am trying to use an Arista Minigraph to bring up the sonic vs.
So I need to use the corresponding port_config.ini [x86_64-arista_7050_qx32/Arista-7050-QX32/port_config.ini] otherwise it does not get configured correctly.

@taoyl-ms
Copy link
Contributor

The correct solution should be renaming the platform name to a vs-specific name and let create symbol links for vs-supported skus under it. Reusing the Force10 platform string for virtual switch is confusing.

@stcheng
Copy link
Contributor

stcheng commented Aug 29, 2018

@taoyl-ms agree.

@lguohan
Copy link
Collaborator

lguohan commented Aug 30, 2018

@NehaRajeM , it can support arista device. @taoyl-ms , we have discussed the separate the alias from port_config.ini for virtual switch. any progress on that?

@yxieca
Copy link
Contributor

yxieca commented Sep 19, 2019

We have different hwskus on vs now. this issue has been addressed.

@yxieca yxieca closed this as completed Sep 19, 2019
prsunny added a commit that referenced this issue Oct 29, 2021
Commits:
f147d9e - 2021-10-27 : [Mux orch] Handle setting unknown mux state (#1984) [Prince Sunny]
4618b2b - 2021-10-28 : Change tunnel orch order (#1990) [Prince Sunny]
505d52d - 2021-10-20 : Fix the option missing in kernel config issue (#1973) [xumia]
7bf4dfb - 2021-10-18 : SAI_REDIS_SWITCH_ATTR_CONTEXT shouldbe the last attribute. This is what sairedis library expects (#1935) [judyjoseph]
c58919e - 2021-10-08 : [logfile][202012]: Add option to specify swss rec file name (#1946) [judyjoseph]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants