Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lm75 doesn't support written alarm to syslog. #2646

Closed
TencentSwitchGroup opened this issue Mar 6, 2019 · 5 comments
Closed

lm75 doesn't support written alarm to syslog. #2646

TencentSwitchGroup opened this issue Mar 6, 2019 · 5 comments
Assignees
@jleveque

Comments

@TencentSwitchGroup
Copy link

First of all, it's not a sonic-buildimage issue. But I think it's OK to commit this issue here.

Linux kernel supports written temperature sensors alarm to syslog, only when the temperature sensors support alarm registers. But not all temperature sensors support this feature, for example LM75.

Many vendors use LM75, but SONiC doesn't define how to written a syslog when the temperature is higher then Thigh or lower than Tlow.

Will SONiC define a way to write such syslog?
@xinliu-seattle
Copy link
Contributor

@TencentSwitchGroup please help to clarify the issue. Your link is related to LM78 not LM75?

@TencentSwitchGroup
Copy link
Author

LM75 is https://github.com/torvalds/linux/blob/master/drivers/hwmon/lm75.c.

It's obviously that kernel support alarm feature in lm77/lm78, but not lm75.
I tested lm75 before, by setting Thigh lower that current temperature, but no syslog found.

@jleveque
Copy link
Contributor

jleveque commented Jul 3, 2019 •
edited
Loading

Hi @TencentSwitchGroup. Once we transition to the new SONiC platform API, all sensor data will be retrieved using the new platform API and logging alarms to syslog will be handled by a new SONiC daemon which retrieves sensor data using the new API.

@TencentSwitchGroup
Copy link
Author

Great!
I also work on this now and plan to implement a syslog daemon. The daemon will record peripheral equipment events, such as high temperature alarm, fan / psu plug in or plug out.

@jleveque
Copy link
Contributor

Closing, as the new platform API will eventually eliminate the need for lm-sensors in SONiC.

@StormLiangMS StormLiangMS mentioned this issue Mar 4, 2023
Merged
8 tasks
StormLiangMS added a commit that referenced this issue Mar 5, 2023
@StormLiangMS
[submodule advance] advance sonic-swss 309df59 #14076
ac14a3a 
Why I did it
submodule advance for master branch

309df59 - Revert "[aclorch] Fixed issue [Mellanox] Update SDK to v4.2.9102 #2204.Support IN_PORTS qualifer in MIRRORV6 table. (Cmd "config vlan member add <vid> <interface_name>" always adds interface as tagged #2668)" (Add warm/fast-boot feature processing for wedge100bf_32x/65x platforms #2687) (85 minutes ago) [StormLiangMS]
ebe8de7 - [FDB]Fixing FDB consolidated flush for Remote MACs (pmon to stretch #2673) (2 days ago) [Sudharsan Dhamal Gopalarathnam]
c9ae6aa - Fix issue: there is no retry while creating a RIF which is in removing state ([201811 sub-module] advance sub-modules: utilities, swss, swss-common #2679) (2 days ago) [Junchao-Mellanox]
79afcb3 - [Dual-ToR] handle 'mux_tunnel_egress_acl' attrib in order to change ACL configuration (drop on ingress/egress) on standby ToR (lm75 doesn't support written alarm to syslog. #2646) (3 days ago) [Andriy Yurkiv]
c2b01ba - [orchagent]: Get bridge port ID from orchagent cache instead of SAI API ([201811 sub module] advance sairedis sub module #2657) (3 days ago) [Lawrence Lee]
d8a1cb7 - [dualtor] Fix neighbor miss when mux is not ready ([mellanox] Fix in mlnx-ffb.sh #2676) (3 days ago) [Longxiang Lyu]
1531dff - [ci] Fix pipeline error about team5 not found. (Core dump in orchagent when assigning router interface to a vlan with untagged mode  #2684) (4 days ago) [Liu Shilong]
cfcd40c - [aclorch] Fixed issue [Mellanox] Update SDK to v4.2.9102 #2204.Support IN_PORTS qualifer in MIRRORV6 table. (Cmd "config vlan member add <vid> <interface_name>" always adds interface as tagged #2668) (4 days ago) [Rajkumar-Marvell]
35a7ab0 - swss: Fix Invalid port oid messages generated because of voq counters. (Failed to update FlexCounter, Segmentation fault #2653) (8 days ago) [Sambath Kumar Balasubramanian]
How I did it
How to verify it
run PR test
@StormLiangMS StormLiangMS mentioned this issue Mar 7, 2023
Merged
8 tasks
StormLiangMS added a commit that referenced this issue Mar 8, 2023
@StormLiangMS
[submodule advance] advance sonic-swss #14116
b144564 
Why I did it
submodule advance

b085b5f - [ci] Fix pipeline error about team5 not found. (Core dump in orchagent when assigning router interface to a vlan with untagged mode  #2684) (3 hours ago) [Liu Shilong]
4549b4c - Fix issue: there is no retry while creating a RIF which is in removing state ([201811 sub-module] advance sub-modules: utilities, swss, swss-common #2679) (3 hours ago) [Junchao-Mellanox]
980a45b - [FDB]Fixing FDB consolidated flush for Remote MACs (pmon to stretch #2673) (3 hours ago) [Sudharsan Dhamal Gopalarathnam]
c646607 - Do not allow to add port to .1Q bridge while router port deletion is not completed (Update SDK, FW and SAI #2669) (3 hours ago) [Lior Avramov]
4a321f0 - [orchagent]: Get bridge port ID from orchagent cache instead of SAI API ([201811 sub module] advance sairedis sub module #2657) (3 hours ago) [Lawrence Lee]
f4b88f3 - [Dual-ToR] handle 'mux_tunnel_egress_acl' attrib in order to change ACL configuration (drop on ingress/egress) on standby ToR (lm75 doesn't support written alarm to syslog. #2646) (3 hours ago) [Andriy Yurkiv]
a4f29c1 - [Workaround] EvpnRemoteVnip2pOrch warmboot check failure ([teamd]: wait for swss db flush done before starting teamd container #2626) (3 hours ago) [jcaiMR]
53ee0a8 - Support for tc-dot1p and tc-dscp qosmap ([201803] [router-advertiser] Add templated script to wait for pertinent interfaces to be ready before starting radvd #2559) (3 hours ago) [Divya Mukundan]
b953866 - [dual-tor] add missing SAI attribte in order to create IPNIP tunnel (Config reload/load_minigraph not clearing State DB #2503) (3 hours ago) [Andriy Yurkiv]
How I did it
How to verify it
xumia pushed a commit to xumia/sonic-buildimage-1 that referenced this issue Mar 10, 2023
@StormLiangMS @xumia
[submodule advance] advance sonic-swss 309df59 sonic-net#14076
a18de71 
Why I did it
submodule advance for master branch

309df59 - Revert "[aclorch] Fixed issue [Mellanox] Update SDK to v4.2.9102 sonic-net#2204.Support IN_PORTS qualifer in MIRRORV6 table. (Cmd "config vlan member add <vid> <interface_name>" always adds interface as tagged sonic-net#2668)" (Add warm/fast-boot feature processing for wedge100bf_32x/65x platforms sonic-net#2687) (85 minutes ago) [StormLiangMS]
ebe8de7 - [FDB]Fixing FDB consolidated flush for Remote MACs (pmon to stretch sonic-net#2673) (2 days ago) [Sudharsan Dhamal Gopalarathnam]
c9ae6aa - Fix issue: there is no retry while creating a RIF which is in removing state ([201811 sub-module] advance sub-modules: utilities, swss, swss-common sonic-net#2679) (2 days ago) [Junchao-Mellanox]
79afcb3 - [Dual-ToR] handle 'mux_tunnel_egress_acl' attrib in order to change ACL configuration (drop on ingress/egress) on standby ToR (lm75 doesn't support written alarm to syslog. sonic-net#2646) (3 days ago) [Andriy Yurkiv]
c2b01ba - [orchagent]: Get bridge port ID from orchagent cache instead of SAI API ([201811 sub module] advance sairedis sub module sonic-net#2657) (3 days ago) [Lawrence Lee]
d8a1cb7 - [dualtor] Fix neighbor miss when mux is not ready ([mellanox] Fix in mlnx-ffb.sh sonic-net#2676) (3 days ago) [Longxiang Lyu]
1531dff - [ci] Fix pipeline error about team5 not found. (Core dump in orchagent when assigning router interface to a vlan with untagged mode  sonic-net#2684) (4 days ago) [Liu Shilong]
cfcd40c - [aclorch] Fixed issue [Mellanox] Update SDK to v4.2.9102 sonic-net#2204.Support IN_PORTS qualifer in MIRRORV6 table. (Cmd "config vlan member add <vid> <interface_name>" always adds interface as tagged sonic-net#2668) (4 days ago) [Rajkumar-Marvell]
35a7ab0 - swss: Fix Invalid port oid messages generated because of voq counters. (Failed to update FlexCounter, Segmentation fault sonic-net#2653) (8 days ago) [Sambath Kumar Balasubramanian]
How I did it
How to verify it
run PR test
mihirpat1 pushed a commit to mihirpat1/sonic-buildimage that referenced this issue Jun 14, 2023
@ayurkiv-nvda
[Dual-ToR] handle 'mux_tunnel_egress_acl' attrib in order to change A…
79afcb3 
…CL configuration (drop on ingress/egress) on standby ToR (sonic-net#2646)

- What I did
Use "mux_tunnel_ingress_acl" to set ACL rules on ingress/egress side depending on attribute value ("disabled/enabled").

- Why I did it
We need to drop data-plane traffic and handle Control-plane traffic in the Dual-ToR scenario.
But we can't do it on Mellanox platform and process traffic on ingress.
To workaround it we can set ACL rules on egress ports, so will process control plane on ingress and drop Data-plane traffic that came from standby port on egress

- How I verified it
check "show mux status" on standby ToR - Mux status should be healthy.
check "show what-just-happened" on standby ToR - no ICMP drop expected on standby ports.

Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jleveque jleveque

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jleveque @xinliu-seattle @TencentSwitchGroup