Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on changing of IP address on a network interface with an active neighbor #289

Closed
garyachy opened this issue Feb 10, 2017 · 1 comment
Closed

Crash on changing of IP address on a network interface with an active neighbor #289

garyachy opened this issue Feb 10, 2017 · 1 comment

Comments

@garyachy
Copy link
Contributor

garyachy commented Feb 10, 2017 •
edited
Loading

Topology
TG-DUT-DUT-TG

Steps

  1. Boot two switches with SONIC (OCP branch) and minigraph
  2. sudo ifconfig Ethernet0 2.2.2.1 netmask 255.255.255.0 on any switch

Observed results
Feb 10 14:23:23 OCPSCH0104001MS NOTICE orchagent: :- removeSubnetRoute: Remove subnet route to 10.10.1.2/30 from Ethernet0
Feb 10 14:23:23 OCPSCH0104001MS NOTICE orchagent: :- removeIp2MeRoute: Remove packet action trap route ip:10.10.1.2
Feb 10 14:23:23 OCPSCH0104001MS NOTICE orchagent: :- removeRouterIntfs: Remove router interface for port Ethernet0
Feb 10 14:23:23 OCPSCH0104001MS ERR orchagent: :- meta_sai_validate_oid: oid is set to null object id
Feb 10 14:23:23 OCPSCH0104001MS ERR orchagent: :- removeRouterIntfs: Failed to remove router interface for port Ethernet0, rv:-5
Feb 10 14:23:23 OCPSCH0104001MS ERR orchagent: :- main: Failed due to exception: Failed to remove router interface.
Feb 10 14:23:23 OCPSCH0104001MS INFO docker[1068]: terminate called without an active exception
Feb 10 14:23:23 OCPSCH0104001MS INFO kernel: [ 1264.781525] Core dump to |/usr/bin/coredump-compress orchagent 91 pipe failed
@stcheng
Copy link
Contributor

stcheng commented Mar 7, 2017

deprecated. this issue shall go to github.com/Azure/SONiC.

@stcheng stcheng closed this as completed Mar 7, 2017
@sihuihan88 sihuihan88 mentioned this issue Jul 25, 2018
Merged
stcheng pushed a commit to stcheng/sonic-buildimage that referenced this issue Jul 19, 2019
[submodule]: Update swss related submodules
6b378b1 
swss:
[vxlanorch]: Allow ipv6 src ip for Vxlan tunnel creation (sonic-net#896)
[aclorch]: Allow DTEL drop actions in DTEL flow watchlist (sonic-net#915)
Fix typo in orchagent_restart_check from fasle to false. (sonic-net#923)
[sonic-swss]: Fix for FPM accept call failure in ARM arch (sonic-net#925)
Add retryCount option for orchagent_restart_check program. (sonic-net#833)
[vlan] Add pytest cases to validate nonexistent vlan behavior. (sonic-net#874)
[intfsorch] Wait for interface prior to prefix (sonic-net#796)
Set timer only when interval changes. Not in each firing of the timer. (sonic-net#945)
[test]: Fix set interface in configuration database (sonic-net#956)
[copporch]: Fix polymorphic type error (sonic-net#946)
[AclOrch]: Fix the acl mirror counter doubled by inactive mirror and active again (sonic-net#952)
[MirrorOrch]: Init the next hop ip with 0 instead of default constructor (sonic-net#953)
[portsorch]: Add reference count of port (sonic-net#962)
[mock_test]: Move mock tests into a separate folder to separate them from vs tests (sonic-net#950)
remove crm acl_counters when acl_table removed (sonic-net#918)
[aclorch]: Fix matching MIRROR_DSCP throws unnecessary errors (sonic-net#966)
[policerorch]: Fix return code comparison error (sonic-net#968)
[gitignore]: Add swss-dbg related files (sonic-net#967)
[vxlanmgrd]: Fix for vxlanmgrd cannot correctly work after config reload (sonic-net#934)
[vxlanorch]: Add extra info into NOTICE logs (sonic-net#891)
[test]: Add a neighbor entry with BCAST MAC and verify its ignored (sonic-net#955)
[copporch]: Fix copporch in DEL command (sonic-net#972)
[orchagent]: Fix crash during orchagent process exit (sonic-net#974)
[vnetorch]: Fix VNET orchagents order for warm-reboot flow (sonic-net#958)
[test]: Skip unstable test test_vnet_orch_1 (sonic-net#976)
[intfsorch]: Fix rif flex counter removal error (sonic-net#975)
Update tests README.md file
[aclorch]: Change CFG_ACL_TABLE_NAME to CFG_ACL_TABLE_TABLE_NAME (sonic-net#978)
[test]: Skip test_watermark.py::TestWatermark::test_lua_plugins (sonic-net#981)
[teamsyncd]: Add information for LAG membership changes (sonic-net#982)

common:
Add an assert to logger, which will log a message and abort. (sonic-net#286)
[test]: Add IpAddress::isZero() unit test (sonic-net#289)
do not abort when read timerfd return 0 and errno = 0 (sonic-net#291)
Add BGP_STATE_TABLE in stateDB (sonic-net#273)
[IpAddress]: add mcast scope on address and isFullMask method on prefix (sonic-net#285)
Add ignore Wshadow pragma to json.hpp (sonic-net#292)
[executor]: Fix Executor does not get correct priority saved in m_selectable (sonic-net#290)
[schema]: Remove duplicate STATE_MIRROR_SESSION_TABLE_NAME (sonic-net#294)
timerfd:read failure - Record in logs as error. (sonic-net#295)
[schema]: Change CFG_ACL_TABLE_NAME to CFG_ACL_TABLE_TABLE_NAME (sonic-net#296)
[schema]: Add PASS_THROUGH_ROUTE_TABLE to config and application db (sonic-net#297)

sairedis:
ARM32 bit fixes, for 64bit printf format specifier (sonic-net#468)
Reduce the timeout (GET_RESPONSE_TIMEOUT) from 6 minutes to 1 minute. (sonic-net#472)
Fixed config_syncd_barefoot function (sonic-net#474)
[syncd_init_common.sh] fix fast reboot backwards compatibility (sonic-net#480)
Add default bridge id for bridge port id of type PORT in virtual switch (sonic-net#473)
Fix a bug in parsing kernel argument of fast-reboot (sonic-net#482)
Add TimerWatchdog for monitoring long execution apis (sonic-net#469)
Add specific comparison logic for tunnel map (sonic-net#475)
[vslib] add ACL action capabilities support (sonic-net#481)
Per buffer pool watermark polling mode (sonic-net#485)
Add specific comparison logic for ACL counter (sonic-net#484)
Process flex counters requests in separate thread (sonic-net#483)
Make sairedis/syncd synchronous (sonic-net#476)
Fixed conditional operator. (sonic-net#487)

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
@stcheng stcheng mentioned this issue Jul 19, 2019
Merged
lguohan pushed a commit that referenced this issue Jul 20, 2019
@stcheng @lguohan
[submodule]: Update swss related submodules (#3190)
01a5bea 
swss:
[vxlanorch]: Allow ipv6 src ip for Vxlan tunnel creation (#896)
[aclorch]: Allow DTEL drop actions in DTEL flow watchlist (#915)
Fix typo in orchagent_restart_check from fasle to false. (#923)
[sonic-swss]: Fix for FPM accept call failure in ARM arch (#925)
Add retryCount option for orchagent_restart_check program. (#833)
[vlan] Add pytest cases to validate nonexistent vlan behavior. (#874)
[intfsorch] Wait for interface prior to prefix (#796)
Set timer only when interval changes. Not in each firing of the timer. (#945)
[test]: Fix set interface in configuration database (#956)
[copporch]: Fix polymorphic type error (#946)
[AclOrch]: Fix the acl mirror counter doubled by inactive mirror and active again (#952)
[MirrorOrch]: Init the next hop ip with 0 instead of default constructor (#953)
[portsorch]: Add reference count of port (#962)
[mock_test]: Move mock tests into a separate folder to separate them from vs tests (#950)
remove crm acl_counters when acl_table removed (#918)
[aclorch]: Fix matching MIRROR_DSCP throws unnecessary errors (#966)
[policerorch]: Fix return code comparison error (#968)
[gitignore]: Add swss-dbg related files (#967)
[vxlanmgrd]: Fix for vxlanmgrd cannot correctly work after config reload (#934)
[vxlanorch]: Add extra info into NOTICE logs (#891)
[test]: Add a neighbor entry with BCAST MAC and verify its ignored (#955)
[copporch]: Fix copporch in DEL command (#972)
[orchagent]: Fix crash during orchagent process exit (#974)
[vnetorch]: Fix VNET orchagents order for warm-reboot flow (#958)
[test]: Skip unstable test test_vnet_orch_1 (#976)
[intfsorch]: Fix rif flex counter removal error (#975)
Update tests README.md file
[aclorch]: Change CFG_ACL_TABLE_NAME to CFG_ACL_TABLE_TABLE_NAME (#978)
[test]: Skip test_watermark.py::TestWatermark::test_lua_plugins (#981)
[teamsyncd]: Add information for LAG membership changes (#982)

common:
Add an assert to logger, which will log a message and abort. (#286)
[test]: Add IpAddress::isZero() unit test (#289)
do not abort when read timerfd return 0 and errno = 0 (#291)
Add BGP_STATE_TABLE in stateDB (#273)
[IpAddress]: add mcast scope on address and isFullMask method on prefix (#285)
Add ignore Wshadow pragma to json.hpp (#292)
[executor]: Fix Executor does not get correct priority saved in m_selectable (#290)
[schema]: Remove duplicate STATE_MIRROR_SESSION_TABLE_NAME (#294)
timerfd:read failure - Record in logs as error. (#295)
[schema]: Change CFG_ACL_TABLE_NAME to CFG_ACL_TABLE_TABLE_NAME (#296)
[schema]: Add PASS_THROUGH_ROUTE_TABLE to config and application db (#297)

sairedis:
ARM32 bit fixes, for 64bit printf format specifier (#468)
Reduce the timeout (GET_RESPONSE_TIMEOUT) from 6 minutes to 1 minute. (#472)
Fixed config_syncd_barefoot function (#474)
[syncd_init_common.sh] fix fast reboot backwards compatibility (#480)
Add default bridge id for bridge port id of type PORT in virtual switch (#473)
Fix a bug in parsing kernel argument of fast-reboot (#482)
Add TimerWatchdog for monitoring long execution apis (#469)
Add specific comparison logic for tunnel map (#475)
[vslib] add ACL action capabilities support (#481)
Per buffer pool watermark polling mode (#485)
Add specific comparison logic for ACL counter (#484)
Process flex counters requests in separate thread (#483)
Make sairedis/syncd synchronous (#476)
Fixed conditional operator. (#487)

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
Kalimuthu-Velappan pushed a commit to Kalimuthu-Velappan/sonic-buildimage that referenced this issue Sep 12, 2019
@sihuihan88
[counterpoll]: output default value when not configured (sonic-net#289)
747d5c3 
Signed-off-by: Sihui Han <sihan@microsoft.com>
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this issue Mar 23, 2020
@jleveque
[orchagent]: Update usage statement to reflect new recording file nam…
8c922a5 
…es (sonic-net#289)
dmytroxshevchuk pushed a commit to dmytroxshevchuk/sonic-buildimage that referenced this issue Aug 31, 2020
@sihuihan88 @lguohan
[Flex_counter]: Remove poll interval from db key (sonic-net#289)
dc38653 
Signed-off-by: Sihui Han <sihan@microsoft.com>
sg893052 pushed a commit to sg893052/sonic-buildimage that referenced this issue Apr 25, 2022
@abhishekd-brcm
Merge pull request sonic-net#289 from abhishekd0/sonic_4_0_0_acl_hld
fce8c59 
SONiC 4.0.0 : ACL based replication and consistency checker
@yxieca yxieca mentioned this issue Sep 8, 2022
Merged
yxieca added a commit to yxieca/sonic-buildimage that referenced this issue Sep 9, 2022
@yxieca
[202205][linkmgrd][utilities][platform-daemons][platform-common][linu…
4bc2354 
…x-kernel] advance submodule head

linkmgrd:
* ab5b2c1 2022-09-02 | Fix mux config (sonic-net#128) (HEAD -> 202205, github/202205) [Longxiang Lyu]

utilities:
* 7de9305 2022-09-07 | [generate dump]Added error message when saisdkdump fails (sonic-net#2356) (HEAD -> 202205, github/202205) [Sudharsan Dhamal Gopalarathnam]
* c5b0a6d 2022-09-07 | [counterpoll]Fixing counterpoll show for tunnel and acl stats (sonic-net#2355) [Sudharsan Dhamal Gopalarathnam]
* 1452b44 2022-09-05 | [GCU] Fix missing backend in dry run (sonic-net#2347) [jingwenxie]
* bc7b845 2022-09-04 | Add Password Hardening CLI support (sonic-net#2338) [davidpil2002]
* 55e8948 2022-09-06 | [fast-reboot]Avoid stopping masked services during fast-reboot (sonic-net#2335) [Sudharsan Dhamal Gopalarathnam]
* f7d69d4 2022-08-30 | Replace cmp in acl_loader with operator.eq (sonic-net#2328) [Zhaohui Sun]
* 4054ebb 2022-09-05 | Add verification for override (sonic-net#2305) [jingwenxie]
* 729d811 2022-05-30 | Fix sonic-installer and 'show version' command crash when database docker not running issue. (sonic-net#2183) [Hua Liu]

platform-daemons:
* 36ba7c0 2022-09-07 | [ycable] cleanup logic for creating grpc future ready (sonic-net#289) (HEAD -> 202205) [vdahiya12]
* 2a9db73 2022-09-01 | [ycabled] fix insert events from xcvrd;cleanup some mux toggle logic (sonic-net#287) [vdahiya12]

platform-common:
* d7c990d 2022-09-03 | [CMIS] 'get_transceiver_info' should return 'None' when CMIS cable EEPROM is not ready  (sonic-net#305) (HEAD -> 202205) [Kebo Liu]

linux-kernel:
* 25ea052 2022-08-31 | [patch]: Add accpt_untracked_na kernel param (sonic-net#292) (HEAD -> 202205) [Lawrence Lee]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca added a commit that referenced this issue Sep 10, 2022
@yxieca
[202205][linkmgrd][utilities][platform-daemons][platform-common][linu…
6812cf0 
…x-kernel] advance submodule head (#12025)

linkmgrd:
* ab5b2c1 2022-09-02 | Fix mux config (#128) (HEAD -> 202205, github/202205) [Longxiang Lyu]

utilities:
* 7de9305 2022-09-07 | [generate dump]Added error message when saisdkdump fails (#2356) (HEAD -> 202205, github/202205) [Sudharsan Dhamal Gopalarathnam]
* c5b0a6d 2022-09-07 | [counterpoll]Fixing counterpoll show for tunnel and acl stats (#2355) [Sudharsan Dhamal Gopalarathnam]
* 1452b44 2022-09-05 | [GCU] Fix missing backend in dry run (#2347) [jingwenxie]
* bc7b845 2022-09-04 | Add Password Hardening CLI support (#2338) [davidpil2002]
* 55e8948 2022-09-06 | [fast-reboot]Avoid stopping masked services during fast-reboot (#2335) [Sudharsan Dhamal Gopalarathnam]
* f7d69d4 2022-08-30 | Replace cmp in acl_loader with operator.eq (#2328) [Zhaohui Sun]
* 4054ebb 2022-09-05 | Add verification for override (#2305) [jingwenxie]
* 729d811 2022-05-30 | Fix sonic-installer and 'show version' command crash when database docker not running issue. (#2183) [Hua Liu]

platform-daemons:
* 36ba7c0 2022-09-07 | [ycable] cleanup logic for creating grpc future ready (#289) (HEAD -> 202205) [vdahiya12]
* 2a9db73 2022-09-01 | [ycabled] fix insert events from xcvrd;cleanup some mux toggle logic (#287) [vdahiya12]

platform-common:
* d7c990d 2022-09-03 | [CMIS] 'get_transceiver_info' should return 'None' when CMIS cable EEPROM is not ready  (#305) (HEAD -> 202205) [Kebo Liu]

linux-kernel:
* 25ea052 2022-08-31 | [patch]: Add accpt_untracked_na kernel param (#292) (HEAD -> 202205) [Lawrence Lee]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@vdahiya12 vdahiya12 mentioned this issue Nov 17, 2022
Merged
7 tasks
vdahiya12 added a commit to vdahiya12/sonic-buildimage that referenced this issue Nov 17, 2022
@vdahiya12
[sonic-platform-daemons] submodule update
e1d84c6 
git log --oneline 7c0a326..master
e8c5657 (HEAD -> master, origin/master, origin/HEAD) [ycabled] fix
exception-handling logic for ycabled (sonic-net#306)
905874d [ycabled] move swsscommon API's from subroutines to call them
exactly once per task_worker/thread (sonic-net#303)
510d330 Fix typo in xcvrd (sonic-net#313)
9ae551f [ycabled] add support for detach mode in 'active-active'
topology (sonic-net#309)
82fc7a6 Added filtering logic to send filtered fields from DB event
(sonic-net#307)
8a2dad9 [ycabled] fix no port/state returned by grpc server (sonic-net#308)
4ea12cf Fix xcvrd to support 400G ZR optic (sonic-net#293)
23b6970 [ycabled] fix naming error for error condition for CLI handling
(sonic-net#302)
501abb2 [ycabled] add some exception catching logic to some vendor
specific API's (sonic-net#301)
534f839 [ycabled] add support for getting grpc secerts via shared file
(sonic-net#298)
3622aac Remove shell=True (sonic-net#300)
143422b add support to execute new ycable API's, add datetime field to
mux_info (sonic-net#297)
6522c46 [ycabled] add notification for gRPC connection state transitions
to  IDLE/TRANSIENT_FAILURE (sonic-net#295)
4b3b238 Install libyang to azure pipeline (sonic-net#292)
8ff5f37 Use get() to fetch default value from dictionary for port
admin_status sonic-net#286
b03cc74 [Xcvrd] Soak duplicate events and process only updated
interested events (sonic-net#285)
3acb171 [ycable] cleanup logic for creating grpc future ready (sonic-net#289)
ce3b6db [ycabled] fix insert events from xcvrd;cleanup some mux toggle
logic (sonic-net#287)

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
stephenxs added a commit to stephenxs/sonic-buildimage that referenced this issue Nov 22, 2022
@stephenxs
Update submodule sonic-platform-daemons
aea648b 
ed818f8 [PSU daemon] Support PSU power threshold checking (sonic-net#288)
707a720 [chassisd] update chassisd to write fabric and lc asics on sep erate table (sonic-net#311)
e8c5657 [ycabled] fix exception-handling logic for ycabled (sonic-net#306)
905874d [ycabled] move swsscommon API's from subroutines to call them exactly once per task_worker/thread (sonic-net#303)
510d330 Fix typo in xcvrd (sonic-net#313)
9ae551f [ycabled] add support for detach mode in 'active-active' topology (sonic-net#309)
82fc7a6 Added filtering logic to send filtered fields from DB event (sonic-net#307)
8a2dad9 [ycabled] fix no port/state returned by grpc server (sonic-net#308)
4ea12cf Fix xcvrd to support 400G ZR optic (sonic-net#293)
23b6970 [ycabled] fix naming error for error condition for CLI handling (sonic-net#302)
501abb2 [ycabled] add some exception catching logic to some vendor specific API's (sonic-net#301)
534f839 [ycabled] add support for getting grpc secerts via shared file (sonic-net#298)
3622aac Remove shell=True (sonic-net#300)
143422b add support to execute new ycable API's, add datetime field to mux_info (sonic-net#297)
6522c46 [ycabled] add notification for gRPC connection state transitions to  IDLE/TRANSIENT_FAILURE (sonic-net#295)
4b3b238 Install libyang to azure pipeline (sonic-net#292)
8ff5f37 Use get() to fetch default value from dictionary for port admin_status sonic-net#286
b03cc74 [Xcvrd] Soak duplicate events and process only updated interested events (sonic-net#285)
3acb171 [ycable] cleanup logic for creating grpc future ready (sonic-net#289)
ce3b6db [ycabled] fix insert events from xcvrd;cleanup some mux toggle logic (sonic-net#287)

Signed-off-by: Stephen Sun <stephens@nvidia.com>
prgeor pushed a commit that referenced this issue Nov 23, 2022
@stephenxs
[submodule] Advance sonic-utilities and sonic-platform-common pointers (
faef4c6 
#12791)

* Update submodule sonic-utilities

72b9cf9 [psushow & psuutil] Support PSU power threshold checking (#2326)
dfdc92e Revert "Support the bandit check by GitHub Action (#2358)" (#2509)
85638b2 YANG Validation for ConfigDB Updates: DEVICE_METADATA, SNMP, SNMP_COMMUNITY tables (#2481)
da44d71 YANG Validation for ConfigDB Updates: PORT_STORM_CONTROL, PORT_QOS_MAP, BUFFER_PROFILE, BUFFER_PG, BUFFER_QUEUE, BUFFER_POOL, FEATURE, DEFAULT_LOSSLESS_BUFFER_PARAMETER tables (#
ba9b628 [sfp] Fix issue: Application Advertisement is not well formatted (#2491)

Signed-off-by: Stephen Sun <stephens@nvidia.com>

* Update submodule sonic-platform-daemons

ed818f8 [PSU daemon] Support PSU power threshold checking (#288)
707a720 [chassisd] update chassisd to write fabric and lc asics on sep erate table (#311)
e8c5657 [ycabled] fix exception-handling logic for ycabled (#306)
905874d [ycabled] move swsscommon API's from subroutines to call them exactly once per task_worker/thread (#303)
510d330 Fix typo in xcvrd (#313)
9ae551f [ycabled] add support for detach mode in 'active-active' topology (#309)
82fc7a6 Added filtering logic to send filtered fields from DB event (#307)
8a2dad9 [ycabled] fix no port/state returned by grpc server (#308)
4ea12cf Fix xcvrd to support 400G ZR optic (#293)
23b6970 [ycabled] fix naming error for error condition for CLI handling (#302)
501abb2 [ycabled] add some exception catching logic to some vendor specific API's (#301)
534f839 [ycabled] add support for getting grpc secerts via shared file (#298)
3622aac Remove shell=True (#300)
143422b add support to execute new ycable API's, add datetime field to mux_info (#297)
6522c46 [ycabled] add notification for gRPC connection state transitions to  IDLE/TRANSIENT_FAILURE (#295)
4b3b238 Install libyang to azure pipeline (#292)
8ff5f37 Use get() to fetch default value from dictionary for port admin_status #286
b03cc74 [Xcvrd] Soak duplicate events and process only updated interested events (#285)
3acb171 [ycable] cleanup logic for creating grpc future ready (#289)
ce3b6db [ycabled] fix insert events from xcvrd;cleanup some mux toggle logic (#287)

Signed-off-by: Stephen Sun <stephens@nvidia.com>

* Update submodule sonic-platform-common

7c48be2 Add warning/critical thresholds for PSU power (#304)
f5ba0d0 Add missing PM and VDM related EEPROM read (#326)
02dd597 implement CMIS set_laser_freq to support 100GHz grid space (#294)

Signed-off-by: Stephen Sun <stephens@nvidia.com>

* Revert "Update submodule sonic-platform-daemons"

This reverts commit aea648b.

Signed-off-by: Stephen Sun <stephens@nvidia.com>
yxieca pushed a commit that referenced this issue Nov 28, 2022
@vdahiya12
[sonic-platform-daemons] submodule update (#12728)
f3809c2 
* [sonic-platform-daemons] submodule update

git log --oneline 7c0a326..master
e8c5657 (HEAD -> master, origin/master, origin/HEAD) [ycabled] fix
exception-handling logic for ycabled (#306)
905874d [ycabled] move swsscommon API's from subroutines to call them
exactly once per task_worker/thread (#303)
510d330 Fix typo in xcvrd (#313)
9ae551f [ycabled] add support for detach mode in 'active-active'
topology (#309)
82fc7a6 Added filtering logic to send filtered fields from DB event
(#307)
8a2dad9 [ycabled] fix no port/state returned by grpc server (#308)
4ea12cf Fix xcvrd to support 400G ZR optic (#293)
23b6970 [ycabled] fix naming error for error condition for CLI handling
(#302)
501abb2 [ycabled] add some exception catching logic to some vendor
specific API's (#301)
534f839 [ycabled] add support for getting grpc secerts via shared file
(#298)
3622aac Remove shell=True (#300)
143422b add support to execute new ycable API's, add datetime field to
mux_info (#297)
6522c46 [ycabled] add notification for gRPC connection state transitions
to  IDLE/TRANSIENT_FAILURE (#295)
4b3b238 Install libyang to azure pipeline (#292)
8ff5f37 Use get() to fetch default value from dictionary for port
admin_status #286
b03cc74 [Xcvrd] Soak duplicate events and process only updated
interested events (#285)
3acb171 [ycable] cleanup logic for creating grpc future ready (#289)
ce3b6db [ycabled] fix insert events from xcvrd;cleanup some mux toggle
logic (#287)

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
StormLiangMS pushed a commit to StormLiangMS/sonic-buildimage that referenced this issue Dec 8, 2022
@stephenxs @StormLiangMS
[submodule] Advance sonic-utilities and sonic-platform-common pointers (
a87a608 
sonic-net#12791)

* Update submodule sonic-utilities

72b9cf9 [psushow & psuutil] Support PSU power threshold checking (sonic-net#2326)
dfdc92e Revert "Support the bandit check by GitHub Action (sonic-net#2358)" (sonic-net#2509)
85638b2 YANG Validation for ConfigDB Updates: DEVICE_METADATA, SNMP, SNMP_COMMUNITY tables (sonic-net#2481)
da44d71 YANG Validation for ConfigDB Updates: PORT_STORM_CONTROL, PORT_QOS_MAP, BUFFER_PROFILE, BUFFER_PG, BUFFER_QUEUE, BUFFER_POOL, FEATURE, DEFAULT_LOSSLESS_BUFFER_PARAMETER tables (#
ba9b628 [sfp] Fix issue: Application Advertisement is not well formatted (sonic-net#2491)

Signed-off-by: Stephen Sun <stephens@nvidia.com>

* Update submodule sonic-platform-daemons

ed818f8 [PSU daemon] Support PSU power threshold checking (sonic-net#288)
707a720 [chassisd] update chassisd to write fabric and lc asics on sep erate table (sonic-net#311)
e8c5657 [ycabled] fix exception-handling logic for ycabled (sonic-net#306)
905874d [ycabled] move swsscommon API's from subroutines to call them exactly once per task_worker/thread (sonic-net#303)
510d330 Fix typo in xcvrd (sonic-net#313)
9ae551f [ycabled] add support for detach mode in 'active-active' topology (sonic-net#309)
82fc7a6 Added filtering logic to send filtered fields from DB event (sonic-net#307)
8a2dad9 [ycabled] fix no port/state returned by grpc server (sonic-net#308)
4ea12cf Fix xcvrd to support 400G ZR optic (sonic-net#293)
23b6970 [ycabled] fix naming error for error condition for CLI handling (sonic-net#302)
501abb2 [ycabled] add some exception catching logic to some vendor specific API's (sonic-net#301)
534f839 [ycabled] add support for getting grpc secerts via shared file (sonic-net#298)
3622aac Remove shell=True (sonic-net#300)
143422b add support to execute new ycable API's, add datetime field to mux_info (sonic-net#297)
6522c46 [ycabled] add notification for gRPC connection state transitions to  IDLE/TRANSIENT_FAILURE (sonic-net#295)
4b3b238 Install libyang to azure pipeline (sonic-net#292)
8ff5f37 Use get() to fetch default value from dictionary for port admin_status sonic-net#286
b03cc74 [Xcvrd] Soak duplicate events and process only updated interested events (sonic-net#285)
3acb171 [ycable] cleanup logic for creating grpc future ready (sonic-net#289)
ce3b6db [ycabled] fix insert events from xcvrd;cleanup some mux toggle logic (sonic-net#287)

Signed-off-by: Stephen Sun <stephens@nvidia.com>

* Update submodule sonic-platform-common

7c48be2 Add warning/critical thresholds for PSU power (sonic-net#304)
f5ba0d0 Add missing PM and VDM related EEPROM read (sonic-net#326)
02dd597 implement CMIS set_laser_freq to support 100GHz grid space (sonic-net#294)

Signed-off-by: Stephen Sun <stephens@nvidia.com>

* Revert "Update submodule sonic-platform-daemons"

This reverts commit aea648b.

Signed-off-by: Stephen Sun <stephens@nvidia.com>
StormLiangMS pushed a commit to StormLiangMS/sonic-buildimage that referenced this issue Dec 8, 2022
@vdahiya12 @StormLiangMS
[sonic-platform-daemons] submodule update (sonic-net#12728)
f398cd1 
* [sonic-platform-daemons] submodule update

git log --oneline 7c0a326..master
e8c5657 (HEAD -> master, origin/master, origin/HEAD) [ycabled] fix
exception-handling logic for ycabled (sonic-net#306)
905874d [ycabled] move swsscommon API's from subroutines to call them
exactly once per task_worker/thread (sonic-net#303)
510d330 Fix typo in xcvrd (sonic-net#313)
9ae551f [ycabled] add support for detach mode in 'active-active'
topology (sonic-net#309)
82fc7a6 Added filtering logic to send filtered fields from DB event
(sonic-net#307)
8a2dad9 [ycabled] fix no port/state returned by grpc server (sonic-net#308)
4ea12cf Fix xcvrd to support 400G ZR optic (sonic-net#293)
23b6970 [ycabled] fix naming error for error condition for CLI handling
(sonic-net#302)
501abb2 [ycabled] add some exception catching logic to some vendor
specific API's (sonic-net#301)
534f839 [ycabled] add support for getting grpc secerts via shared file
(sonic-net#298)
3622aac Remove shell=True (sonic-net#300)
143422b add support to execute new ycable API's, add datetime field to
mux_info (sonic-net#297)
6522c46 [ycabled] add notification for gRPC connection state transitions
to  IDLE/TRANSIENT_FAILURE (sonic-net#295)
4b3b238 Install libyang to azure pipeline (sonic-net#292)
8ff5f37 Use get() to fetch default value from dictionary for port
admin_status sonic-net#286
b03cc74 [Xcvrd] Soak duplicate events and process only updated
interested events (sonic-net#285)
3acb171 [ycable] cleanup logic for creating grpc future ready (sonic-net#289)
ce3b6db [ycabled] fix insert events from xcvrd;cleanup some mux toggle
logic (sonic-net#287)

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
StormLiangMS pushed a commit that referenced this issue Dec 10, 2022
@stephenxs @StormLiangMS
[submodule] Advance sonic-utilities and sonic-platform-common pointers (
a338427 
#12791)

* Update submodule sonic-utilities

72b9cf9 [psushow & psuutil] Support PSU power threshold checking (#2326)
dfdc92e Revert "Support the bandit check by GitHub Action (#2358)" (#2509)
85638b2 YANG Validation for ConfigDB Updates: DEVICE_METADATA, SNMP, SNMP_COMMUNITY tables (#2481)
da44d71 YANG Validation for ConfigDB Updates: PORT_STORM_CONTROL, PORT_QOS_MAP, BUFFER_PROFILE, BUFFER_PG, BUFFER_QUEUE, BUFFER_POOL, FEATURE, DEFAULT_LOSSLESS_BUFFER_PARAMETER tables (#
ba9b628 [sfp] Fix issue: Application Advertisement is not well formatted (#2491)

Signed-off-by: Stephen Sun <stephens@nvidia.com>

* Update submodule sonic-platform-daemons

ed818f8 [PSU daemon] Support PSU power threshold checking (#288)
707a720 [chassisd] update chassisd to write fabric and lc asics on sep erate table (#311)
e8c5657 [ycabled] fix exception-handling logic for ycabled (#306)
905874d [ycabled] move swsscommon API's from subroutines to call them exactly once per task_worker/thread (#303)
510d330 Fix typo in xcvrd (#313)
9ae551f [ycabled] add support for detach mode in 'active-active' topology (#309)
82fc7a6 Added filtering logic to send filtered fields from DB event (#307)
8a2dad9 [ycabled] fix no port/state returned by grpc server (#308)
4ea12cf Fix xcvrd to support 400G ZR optic (#293)
23b6970 [ycabled] fix naming error for error condition for CLI handling (#302)
501abb2 [ycabled] add some exception catching logic to some vendor specific API's (#301)
534f839 [ycabled] add support for getting grpc secerts via shared file (#298)
3622aac Remove shell=True (#300)
143422b add support to execute new ycable API's, add datetime field to mux_info (#297)
6522c46 [ycabled] add notification for gRPC connection state transitions to  IDLE/TRANSIENT_FAILURE (#295)
4b3b238 Install libyang to azure pipeline (#292)
8ff5f37 Use get() to fetch default value from dictionary for port admin_status #286
b03cc74 [Xcvrd] Soak duplicate events and process only updated interested events (#285)
3acb171 [ycable] cleanup logic for creating grpc future ready (#289)
ce3b6db [ycabled] fix insert events from xcvrd;cleanup some mux toggle logic (#287)

Signed-off-by: Stephen Sun <stephens@nvidia.com>

* Update submodule sonic-platform-common

7c48be2 Add warning/critical thresholds for PSU power (#304)
f5ba0d0 Add missing PM and VDM related EEPROM read (#326)
02dd597 implement CMIS set_laser_freq to support 100GHz grid space (#294)

Signed-off-by: Stephen Sun <stephens@nvidia.com>

* Revert "Update submodule sonic-platform-daemons"

This reverts commit aea648b.

Signed-off-by: Stephen Sun <stephens@nvidia.com>
StormLiangMS pushed a commit that referenced this issue Dec 10, 2022
@vdahiya12 @StormLiangMS
[sonic-platform-daemons] submodule update (#12728)
5bc43c2 
* [sonic-platform-daemons] submodule update

git log --oneline 7c0a326..master
e8c5657 (HEAD -> master, origin/master, origin/HEAD) [ycabled] fix
exception-handling logic for ycabled (#306)
905874d [ycabled] move swsscommon API's from subroutines to call them
exactly once per task_worker/thread (#303)
510d330 Fix typo in xcvrd (#313)
9ae551f [ycabled] add support for detach mode in 'active-active'
topology (#309)
82fc7a6 Added filtering logic to send filtered fields from DB event
(#307)
8a2dad9 [ycabled] fix no port/state returned by grpc server (#308)
4ea12cf Fix xcvrd to support 400G ZR optic (#293)
23b6970 [ycabled] fix naming error for error condition for CLI handling
(#302)
501abb2 [ycabled] add some exception catching logic to some vendor
specific API's (#301)
534f839 [ycabled] add support for getting grpc secerts via shared file
(#298)
3622aac Remove shell=True (#300)
143422b add support to execute new ycable API's, add datetime field to
mux_info (#297)
6522c46 [ycabled] add notification for gRPC connection state transitions
to  IDLE/TRANSIENT_FAILURE (#295)
4b3b238 Install libyang to azure pipeline (#292)
8ff5f37 Use get() to fetch default value from dictionary for port
admin_status #286
b03cc74 [Xcvrd] Soak duplicate events and process only updated
interested events (#285)
3acb171 [ycable] cleanup logic for creating grpc future ready (#289)
ce3b6db [ycabled] fix insert events from xcvrd;cleanup some mux toggle
logic (#287)

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
mihirpat1 pushed a commit to mihirpat1/sonic-buildimage that referenced this issue Feb 21, 2023
@vdahiya12
[ycable] cleanup logic for creating grpc future ready (sonic-net#289)
3acb171 
Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com
This PR attempts to remove this call
channel_ready = grpc.channel_ready_future for the ycabled gRPC implementation. The reason to do this is incase of channel not being connected ycabled tries to reattempt the channel creation again with each RPC request from linkmgrd.
This is not the right way to maintain the channels/stubs, and actually adds unrequired overhead for ycabled. This PR supports creating channel/stub in ycabled in correct manner.

Description
Motivation and Context
Required to reduce CPU usage for ycabled

How Has This Been Tested?
Deploying the changes on Arista testbed and UT
yxieca pushed a commit that referenced this issue Oct 13, 2023
@mssonicbld
[submodule] Update submodule sonic-snmpagent to the latest HEAD autom…
956e970 
…atically (#16877)

src/sonic-snmpagent

* 17a8bb2 - (HEAD -> 202205, origin/202205) Add ifhighspeed UT (#296) (5 minutes ago) [Hua Liu]
* b5a52ff - Fix key missing exception when invalied transiver info in STATE_DB (#289) (5 minutes ago) [Hua Liu]
* 09bb0c2 - Fix FdbUpdater crash when SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID attribute missing. (#286) (5 minutes ago) [Hua Liu]
* 792e403 - Support interface speed for PortChannels (#262) (5 minutes ago) [Lukas Stockner]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garyachy @stcheng