Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dhcp_relay]'wait_for_init.sh.j2' translate duplicate if the interface has both ipv4 and ipv6 address #3316

Closed
wangshengjun opened this issue Aug 9, 2019 · 1 comment
Closed

[dhcp_relay]'wait_for_init.sh.j2' translate duplicate if the interface has both ipv4 and ipv6 address #3316

wangshengjun opened this issue Aug 9, 2019 · 1 comment
Assignees
@jleveque
Labels
Enhancement ➕

Comments

@wangshengjun
Copy link
Contributor

wangshengjun commented Aug 9, 2019 •
edited
Loading

Signed-off-by: wangshengjun wangshengjun@asterfusion.com
Steps to reproduce the issue:
1.config the Portchannel interface with ipv4 and ipv6 address
"PORTCHANNEL_INTERFACE": {
"PortChannel0001": {},
"PortChannel0002": {},
"PortChannel0001|10.0.0.56/31": {},
"PortChannel0001|FC00::71/126": {},
"PortChannel0002|10.0.0.58/31": {},
"PortChannel0002|FC00::75/126": {}
},
2. attach the dhcp_relay docker, check the translated script 'wait_for_intf.sh'
docker exec -ti dhcp_relay bash
cat /usr/bin/wait_for_intf.sh
...
Wait for all interfaces to be up and ready
wait_until_iface_ready ${LAG_TABLE_PREFIX} PortChannel0001
wait_until_iface_ready ${LAG_TABLE_PREFIX} PortChannel0001
wait_until_iface_ready ${LAG_TABLE_PREFIX} PortChannel0002
wait_until_iface_ready ${LAG_TABLE_PREFIX} PortChannel0002
...

Expected Result
the function of 'wait_until_iface_ready' called once for each interface.
wangshengjun added a commit to wangshengjun/sonic-buildimage that referenced this issue Aug 9, 2019
@wangshengjun
[dhcp_relay]the function of 'wait_until_iface_ready' called once for …
eb93928 
…each interface.(sonic-net#3316)

Signed-off-by: wangshengjun <wangshengjun@asterfusion.com>
@wangshengjun wangshengjun mentioned this issue Aug 9, 2019
Merged
@jleveque jleveque self-assigned this Aug 9, 2019
@jleveque
Copy link
Contributor

jleveque commented Aug 9, 2019

Resolved via #3317

@jleveque jleveque closed this as completed Aug 9, 2019
wangshengjun added a commit to wangshengjun/sonic-buildimage that referenced this issue Aug 10, 2019
@wangshengjun
[dhcp_relay] fix the compile error for the issue 'sonic-net#3316', ch…
653ed90 
…ange the sample_output file of 'wait_for_intf.sh'. sonic-net#3316

Signed-off-by: wangshengjun <wangshengjun@asterfusion.com>
jleveque pushed a commit that referenced this issue Aug 10, 2019
@wangshengjun @jleveque
[dhcp_relay] fix the compile error introduced by the fixed issue of '#…
70febea 
…3316', change the sample_output file of 'wait_for_intf.sh' (#3325)

Signed-off-by: wangshengjun <wangshengjun@asterfusion.com>
wangshengjun added a commit to wangshengjun/sonic-buildimage that referenced this issue Nov 16, 2020
@wangshengjun
[dhcp_relay] fix the compile error introduced by the fixed issue of 's…
4658546 
…onic-net#3316', change the sample_output file of 'wait_for_intf.sh' (sonic-net#3325)

Signed-off-by: wangshengjun <wangshengjun@asterfusion.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jleveque jleveque

Labels
Enhancement ➕
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jleveque @wangshengjun