Updating index value starts from 0-based in port_config.ini #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- What I did
Update index value from 1-based to 0-based
- How I did it
The below files will be modified:
1. port_config.ini
2. sfputil.py
- How to verify it
Execute command "sfputil show eeprom" to check the eeprom can be dumped if port is pluggged.
- Description for the changelog
Update index value from 1-based to 0-based
Signed-off-by: Sam Yang <yang.kaiyu@gmail.com>
lguohan
approved these changes
Nov 22, 2017
|
The "vs" build failed due to "platform/vs/rules.mk" (see console here). |
|
this is due to the commit is for 201709 branch. |
abdosi
added a commit
that referenced
this pull request
Feb 4, 2020
[aclorch] Enable IN_PORTS ACL qualifier on MIRROR tables (#1176)
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Feb 6, 2020
Submodule src/sonic-swss 0329b678..3348dc13: > [aclorch] Enable IN_PORTS ACL qualifier on MIRROR tables (sonic-net#1176) Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca
added a commit
that referenced
this pull request
Feb 6, 2020
Submodule src/sonic-swss 0329b678..3348dc13: > [aclorch] Enable IN_PORTS ACL qualifier on MIRROR tables (#1176) Signed-off-by: Ying Xie <ying.xie@microsoft.com>
lguohan
pushed a commit
that referenced
this pull request
Feb 9, 2020
Including commits in those repos: sonic-swss-common 7ee1179 2020-01-15 | Add unregister method to NetDispatcher (#326) [Kamil Cudnik] b080150 2019-12-19 | Add resultToString method for Select class (#325) [Kamil Cudnik] sonic-swss 412c5eb 2020-02-06 | Quote input strings before constructing a command line (#1193) [Qi Luo] 1215262 2020-02-06 | [DPB portsyncd/portmgrd/portorch] Support dynamic port add/deletion without dependencies (#1112) [zhenggen-xu] ddb84fb 2020-02-03 | [aclorch] Enable IN_PORTS ACL qualifier on MIRROR tables (#1176) [Danny Allen] 750982e 2020-01-30 | adding mirrorv6 support for mrvl platform (#1190) [B S Rama krishna] 73ab143 2020-01-29 | [pytest]: print out stdout/stderr message when cmd fails (#1188) [lguohan] 1883c0a 2020-01-29 | [vs tests] Remove class-level flaky fixtures (#1189) [Danny Allen] dc695fb 2020-01-29 | [orch] change Consumer class to support multiple values for the same key (#1184) [zhenggen-xu] 49ad38f 2020-01-30 | [orchagent/copp] : copp trap priority not supported for marvell platf… (#1163) [rajkumar38] cbe1811 2020-01-28 | Fix the stack-overflow issue in AclOrch::getTableById() (#1073) [zhenggen-xu] c6a8a04 2020-01-29 | [aclorch]: add support for acl rule to match out port (#810) [shine4chen] 8f4c54a 2020-01-29 | [qosorch] converting shaper bandwidth value to unsigned long instead of int (#1167) [Sabareesh-Kumar-Anandan] 84415f6 2020-01-28 | [vs tests] Activate flaky plugin for virtual switch pytests (#1186) [Danny Allen] 5eb1ea3 2020-01-28 | [qosorch]: Remove Init Color ACLs (#1084) [zhenggen-xu]
pphuchar
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Mar 9, 2020
[aclorch] Enable IN_PORTS ACL qualifier on MIRROR tables (sonic-net#1176)
madhanmellanox
pushed a commit
to madhanmellanox/sonic-buildimage
that referenced
this pull request
Mar 23, 2020
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 24, 2020
[aclorch] Enable IN_PORTS ACL qualifier on MIRROR tables (sonic-net#1176)
3 tasks
3 tasks
lguohan
pushed a commit
that referenced
this pull request
Nov 6, 2020
Add a switch to route_check to control whether write log to syslog (#1215) [consutil] Store console port state in STATE_DB (#1208) [sfputil] Display 'N/A' for non-SFP ports (#1078) Show FG_NHG CLI Commands Added (#1056) [show] remove 'device2interface_dict' in show interface neighbor expected (#1188) Add license file, remove third-party licenses file (#1192) [fwutil]: Set min log priority to INFO. (#1191) [CLI][show][platform] Added ASIC count in the output. (#1185) fdbshow and nbrshow use SonicV2Connector with decode_responses=True, and remove all the decode() (#1187) Remove stdeb.cfg; no longer used now that we build as wheel (#1182) [counterpoll] Disable Counter Poll When Entering Fast Reboot (#1174) Fixes the issue with show interface counters and for pfc and queue counters. (#1180) [config/show] Add CLI support for proxy arp (#1168) [consutil] Add brief option to show line command (#1176) Modify fast-reboot script to use BGP service script to stop bgp service (#1177) [config/console] Support update console configuration related commands (#1166) [consutil] Fix issue where the show line command crash if no ttyUSB exists (#1173) [watermarkstat] Add unit tests for watermarkstat show commands (#1157) Fix exception for ipaddress in python2 (#1164) [celestica] consutil to support customize tty device name (#1155) Signed-off-by: Danny Allen <daall@microsoft.com>
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
Jan 14, 2021
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
Add a switch to route_check to control whether write log to syslog (sonic-net#1215) [consutil] Store console port state in STATE_DB (sonic-net#1208) [sfputil] Display 'N/A' for non-SFP ports (sonic-net#1078) Show FG_NHG CLI Commands Added (sonic-net#1056) [show] remove 'device2interface_dict' in show interface neighbor expected (sonic-net#1188) Add license file, remove third-party licenses file (sonic-net#1192) [fwutil]: Set min log priority to INFO. (sonic-net#1191) [CLI][show][platform] Added ASIC count in the output. (sonic-net#1185) fdbshow and nbrshow use SonicV2Connector with decode_responses=True, and remove all the decode() (sonic-net#1187) Remove stdeb.cfg; no longer used now that we build as wheel (sonic-net#1182) [counterpoll] Disable Counter Poll When Entering Fast Reboot (sonic-net#1174) Fixes the issue with show interface counters and for pfc and queue counters. (sonic-net#1180) [config/show] Add CLI support for proxy arp (sonic-net#1168) [consutil] Add brief option to show line command (sonic-net#1176) Modify fast-reboot script to use BGP service script to stop bgp service (sonic-net#1177) [config/console] Support update console configuration related commands (sonic-net#1166) [consutil] Fix issue where the show line command crash if no ttyUSB exists (sonic-net#1173) [watermarkstat] Add unit tests for watermarkstat show commands (sonic-net#1157) Fix exception for ipaddress in python2 (sonic-net#1164) [celestica] consutil to support customize tty device name (sonic-net#1155) Signed-off-by: Danny Allen <daall@microsoft.com>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
May 10, 2021
Signed-off-by: Jing Kan jika@microsoft.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Update index value from 1-based to 0-based
- How I did it
The below files will be modified:
- How to verify it
Execute command "sfputil show eeprom" to check the eeprom can be dumped if port is pluggged
- Description for the changelog
Update index value from 1-based to 0-based
Signed-off-by: Sam Yang yang.kaiyu@gmail.com