[202012] Replace VLAN table with DHCP_RELAY table for verifying ipv6 helpers and add unittests #11794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kellyyeh do we need this in 202012? |
|
@kellyyeh , can you please add [202012] to title and also the PR thats merged to master? |
5 tasks
kellyyeh
changed the title
kellyyeh
force-pushed
the
dhcprelay-table
branch
from
886f91c
to
346e811
Compare
kellyyeh
changed the title
kellyyeh
added
Request for 202111 Branch
yxieca
approved these changes
Aug 24, 2022
|
@kellyyeh 202205 is already having dhcp in submodule. Please advance submodule head instead. |
|
@yxieca This change is in docker-dhcp-relay and sonic-config-engine, no changes in sonic-dhcp-relay |
richardyu-ms
pushed a commit
to richardyu-ms/sonic-buildimage
that referenced
this pull request
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #10654
Why I did it
dhcp6relay reads ipv6 helpers from DHCP_RELAY table. Docker supervisord should rely on DHCP_RELAY instead of VLAN table to determine if dhcpv6 relay needs to be started. Added "vlan missing ip helper" dhcp relay unittest
How I did it
Change docker supervisord to check for DHCP_RELAY table for ipv6 helpers
Added unittests
How to verify it
Run dhcp_relay docker, ensure ipv6 helper is present is only DHCP_RELAY table and not VLAN table, and dhcp6relay should start up
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)