[nokia] Replace os.system and remove subprocess with shell=True #12100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: maipbui <maibui@microsoft.com>
Signed-off-by: maipbui <maibui@microsoft.com>
Signed-off-by: maipbui <maibui@microsoft.com>
Signed-off-by: maipbui <maibui@microsoft.com>
qiluo-msft
reviewed
Sep 18, 2022
| os.system("echo 24c02 0x53 > /sys/class/i2c-adapter/i2c-0/new_device") | ||
| file = "/sys/class/i2c-adapter/i2c-0/new_device" | ||
| with open(file, 'w') as f: | ||
| f.write('24c02 0x53') |
qiluo-msft
reviewed
Sep 18, 2022
| @@ -331,7 +327,7 @@ def set_status_led(self, color): | |||
|
|
|||
| # Write sys led | |||
| if smbus_present == 0: # called from host (e.g. 'show system-health') | |||
| cmdstatus, value = cmd.getstatusoutput('sudo i2cset -y 0 0x41 0x7 %d' % value) | |||
| cmdstatus, value = getstatusoutput_noshell(['sudo', 'i2cset', '-y', '0', '0x41', '0x7', value]) | |||
Signed-off-by: maipbui <maibui@microsoft.com>
qiluo-msft
approved these changes
Sep 19, 2022
maipbui
added
Request for 201911 Branch 
Request for 202006 Branch
Request for 202012 Branch
Request for 202106 Branch
Request for 202111 Branch
Signed-off-by: maipbui <maibui@microsoft.com>
|
@carl-nokia @dflynn-Nokia Could you help review and verify? |
|
@mlok-nokia Could you help review and verify? |
maipbui
removed
Request for 201911 Branch
Request for 202006 Branch
Request for 202012 Branch
Request for 202106 Branch
Request for 202111 Branch
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@Blueve is connecting Nokia reviewers. |
|
I am ok with the change. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: maipbui maibui@microsoft.com
Dependency: #12065
Why I did it
subprocess.Popen()andsubprocess.run()is used withshell=True, which is very dangerous for shell injection.os- not secure against maliciously constructed input and dangerous if used to evaluate dynamic contentgetstatusoutputis dangerous because it containsshell=Truein the implementationHow I did it
Replace
osbysubprocess, use withshell=FalseRemove unused functions
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)