Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed nokia platform m0 asic mismatch #12148

Merged
merged 1 commit into from
Oct 11, 2022
Merged

fixed nokia platform m0 asic mismatch #12148

merged 1 commit into from
Oct 11, 2022

Conversation

hehuang-nokia
Copy link
Contributor

@hehuang-nokia hehuang-nokia commented Sep 21, 2022

changed the platform device name under nokia directory; we now need to specify marvell armhf/arm64 to provide more accurate platform identity. otherwise onie discovery won't recognize the asic being installed.

Why I did it

when we load images using onie discovery, the process was failing because of marvell ASIC mismatch

How I did it

replace the platform asic with marvell-armhf under 7215

How to verify it

load a new image using http server and verify that the image can be loaded successfully

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

changed the platform device name under nokia directory;
we now need to specify marvell armhf/arm64 to provide more accurate
platform identity. otherwise onie discovery won't recognize the asic
being installed.
@Blueve
Copy link
Contributor

Blueve commented Sep 22, 2022

@yaqiangz for awareness. Some of tests were skipped by checking asic_type == 'marvell', now we'd better update these condition to 'marvell' in asic_type

@Blueve
Copy link
Contributor

Blueve commented Sep 22, 2022

@hehuang-nokia which release branch will be impacted by this issue? Do you want to this fix backport to 202012 and 202205?

@hehuang-nokia
Copy link
Contributor Author

@hehuang-nokia which release branch will be impacted by this issue? Do you want to this fix backport to 202012 and 202205?

I tested latest 202205 which also has the issue but have not seen the problem in 202012 yet. tests ongoing. will update and mark 202012 if problem found.

@hehuang-nokia
Copy link
Contributor Author

@yaqiangz @Blueve Hi, regarding the checks that were unsuccessful in this PR, is PR 6401 attempting to fix them?

@Blueve
Copy link
Contributor

Blueve commented Sep 27, 2022

@hehuang-nokia Current PR issue is not related to PR 6401. We raise PR 6401 was due to we are skipping some sonic-mgmt test cases by checking the asic_type and we need to update them accordingly.

For your PR, the build failure seems like caused by transient network issue. I will rerun these build pipelines

@Blueve
Copy link
Contributor

Blueve commented Sep 27, 2022

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Blueve
Copy link
Contributor

Blueve commented Sep 29, 2022

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Blueve
Copy link
Contributor

Blueve commented Sep 30, 2022

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Blueve pushed a commit to sonic-net/sonic-mgmt that referenced this pull request Sep 30, 2022
)

What is the motivation for this PR?
Asic of Nokia-7215 was replaced by sonic-net/sonic-buildimage#12148, which will cause skip failure about Nokia-7215

How did you do it?
Modify skip conditions.
@Blueve
Copy link
Contributor

Blueve commented Oct 1, 2022

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Blueve
Copy link
Contributor

Blueve commented Oct 10, 2022

/easycla

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 10, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: hehuang-nokia / name: henry huang (5a5ceb2)

@Blueve
Copy link
Contributor

Blueve commented Oct 10, 2022

@hehuang-nokia could you sign CLA per above instruction?

@hehuang-nokia
Copy link
Contributor Author

@hehuang-nokia could you sign CLA per above instruction?

Thanks for the reminder and instructions. It has been signed.

@Blueve Blueve merged commit cb707b7 into sonic-net:master Oct 11, 2022
renukamanavalan added a commit that referenced this pull request Oct 12, 2022
| * cb707b7 fixed nokia platform m0 asic mismatch (fixed nokia platform m0 asic mismatch #12148)
| * c75dfe8 [build] Fix dpkg front lock issue with apt-get ([build] Fix dpkg front lock issue caused by apt-get install #12332)
| * 247bd78 [action] Fix PR pre-cherry-pick action wrong author issue. ([action] Fix PR pre-cherry-pick action wrong author issue. #12339)
| * fc99265 [Nokia] Update the nokia platform submodule for Nokia-IXR7250E platform ([Nokia] Update the nokia platform submodule for Nokia-IXR7250E platform #12305)
| * 9d37b63 [Nokia] Update Nokia platform IXR7250E device data ([Nokia] Update Nokia platform IXR7250E device data #11611)
| * 304c6c8 [BFN] Reworked BFN platform thermals plugin ([BFN] Reworked BFN platform thermals plugin #11723)
| * df93a1b [Build][Bug] Fix apt-get remove version not lock issue ([Build][Bug] Fix apt-get remove version not locked issue #12193)
| * 9b2b8e3 Add gearbox taps to vs gearbox_config.json (Add gearbox taps to vs gearbox_config.json #11480)
wangxin pushed a commit to sonic-net/sonic-mgmt that referenced this pull request Oct 14, 2022
)

What is the motivation for this PR?
Asic of Nokia-7215 was replaced by sonic-net/sonic-buildimage#12148, which will cause skip failure about Nokia-7215

How did you do it?
Modify skip conditions.
Azarack pushed a commit to Azarack/sonic-mgmt that referenced this pull request Oct 17, 2022
…nic-net#6401)

What is the motivation for this PR?
Asic of Nokia-7215 was replaced by sonic-net/sonic-buildimage#12148, which will cause skip failure about Nokia-7215

How did you do it?
Modify skip conditions.
@Blueve
Copy link
Contributor

Blueve commented Oct 24, 2022

@yxieca Could you help back port this fix to 202205?

yxieca pushed a commit that referenced this pull request Oct 25, 2022
changed the platform device name under nokia directory; we now need to specify marvell armhf/arm64 to provide more accurate platform identity. otherwise onie discovery won't recognize the asic being installed.

Why I did it
when we load images using onie discovery, the process was failing because of marvell ASIC mismatch

How I did it
replace the platform asic with marvell-armhf under 7215

How to verify it
load a new image using http server and verify that the image can be loaded successfully
allen-xf pushed a commit to allen-xf/sonic-mgmt that referenced this pull request Oct 28, 2022
…nic-net#6401)

What is the motivation for this PR?
Asic of Nokia-7215 was replaced by sonic-net/sonic-buildimage#12148, which will cause skip failure about Nokia-7215

How did you do it?
Modify skip conditions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants