Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rc.local]: Add chassis serial number to DEVICE_METADATA table. #1235

Closed
wants to merge 1 commit into from
Closed

[rc.local]: Add chassis serial number to DEVICE_METADATA table. #1235

wants to merge 1 commit into from

Conversation

oleksandrivantsiv
Copy link
Collaborator

Required for SNMP agent.

svc-acs
svc-acs previously requested changes Dec 13, 2017
View reviewed changes
Copy link
Collaborator

@svc-acs svc-acs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will delay the boot process which is critical to the fast-reboot. Can you add this into pmon docker start process, and add it to configdb?

@lguohan
Copy link
Collaborator

lguohan commented Dec 13, 2017

this will delay the boot process which is critical to the fast-reboot. Can you add this into pmon docker start process, and add it to configdb?

lguohan
lguohan requested changes Dec 13, 2017
View reviewed changes
Copy link
Collaborator

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as comments

@taoyl-ms
Copy link
Contributor

Is chassis serial number configurable? Why do we want to add it into configDB?

@marian-pritsak
Copy link
Collaborator

Deprecated. Refer to #1246

abdosi added a commit that referenced this pull request Apr 20, 2020
@abdosi
[Submodule update] swss with following PR's:
4324f30 
 Do not set PG to Buffer porfile mapping again if already exist. (#1261)
[sub intf] Use m_lag_id to be the parent port object id when parent port
is LAG (#1235)
@dzhangalibaba dzhangalibaba mentioned this pull request Apr 20, 2020
Merged
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 24, 2020
@abdosi @tiantianlv
[Submodule update] swss with following PR's:
6a9d7b0 
 Do not set PG to Buffer porfile mapping again if already exist. (sonic-net#1261)
[sub intf] Use m_lag_id to be the parent port object id when parent port
is LAG (sonic-net#1235)
@judyjoseph judyjoseph mentioned this pull request Apr 25, 2020
Merged
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request Jan 14, 2021
@wendani @abdosi
[sub intf] Use m_lag_id to be the parent port object id when parent p…
e9cf94a 
…ort is LAG (sonic-net#1235)

Fix to sonic-net#4142

Add vs test on lag sub interface based on unconventional lag naming "PortChannel1.20" to fit the interface name within 15 characters

Signed-off-by: Wenda Ni wonda.ni@gmail.com
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022
@wendani
[sub intf] Use m_lag_id to be the parent port object id when parent p…
d6236b5 
…ort is LAG (sonic-net#1235)

Fix to sonic-net#4142

Add vs test on lag sub interface based on unconventional lag naming "PortChannel1.20" to fit the interface name within 15 characters

Signed-off-by: Wenda Ni wonda.ni@gmail.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan requested changes

@svc-acs svc-acs svc-acs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oleksandrivantsiv @lguohan @taoyl-ms @marian-pritsak @svc-acs