Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The build project of s3ip framework #12896

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

tianshangfei
Copy link
Contributor

@tianshangfei tianshangfei commented Nov 30, 2022

Signed-off-by: tianshangfei tian_shangfei@163.com

Why I did it

The build project of s3ip framework

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

The s3ip framework

  • 202211

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: tianshangfei <tian_shangfei@163.com>
@adyeung
Copy link
Collaborator

adyeung commented Nov 30, 2022

@FuzailBrcm pls help review

1 similar comment
@tianshangfei
Copy link
Contributor Author

@FuzailBrcm pls help review

@FuzailBrcm
Copy link
Contributor

  • Are you building these packages as part of SONiC binary ?

  • How does these package integrate with the full build? Is there any config option to enable S3IP .deb packages to be part of SONiC binary ?

@tianshangfei
Copy link
Contributor Author

  • Are you building these packages as part of SONiC binary ?
  • How does these package integrate with the full build? Is there any config option to enable S3IP .deb packages to be part of SONiC binary ?

This deb package is only used to generate a demo of how to install and use the s3ip framework in the development environment. Because there is no adaptation to a specific platform and some kernel modules need to be tailored, deb packages will not be included directly in the SONiC binary.

Platform-specific developers, according to the requirements, cut the kernel module of the S3IP sysfs framework, generate the configuration file of the S3ip sysfs framework, and finally embed (or soft-link) the S3IP sysfs framework into the specific platform code.

@FuzailBrcm
Copy link
Contributor

FuzailBrcm commented Dec 14, 2022

  • Are you building these packages as part of SONiC binary ?
  • How does these package integrate with the full build? Is there any config option to enable S3IP .deb packages to be part of SONiC binary ?

This deb package is only used to generate a demo of how to install and use the s3ip framework in the development environment. Because there is no adaptation to a specific platform and some kernel modules need to be tailored, deb packages will not be included directly in the SONiC binary.

Platform-specific developers, according to the requirements, cut the kernel module of the S3IP sysfs framework, generate the configuration file of the S3ip sysfs framework, and finally embed (or soft-link) the S3IP sysfs framework into the specific platform code.

Please share the commands to build the S3ip .deb packages

@tianshangfei
Copy link
Contributor Author

  • Are you building these packages as part of SONiC binary ?
  • How does these package integrate with the full build? Is there any config option to enable S3IP .deb packages to be part of SONiC binary ?

This deb package is only used to generate a demo of how to install and use the s3ip framework in the development environment. Because there is no adaptation to a specific platform and some kernel modules need to be tailored, deb packages will not be included directly in the SONiC binary.
Platform-specific developers, according to the requirements, cut the kernel module of the S3IP sysfs framework, generate the configuration file of the S3ip sysfs framework, and finally embed (or soft-link) the S3IP sysfs framework into the specific platform code.

Please share the commands to build the S3ip .deb packages

This command is covered in the "Porting guide" section of the S3ip sysfs HLD pr.
Generate a host package, run the following command
sonic-buildimage/platform/s3ip-sysfs/build.sh

Copy link
Contributor

@FuzailBrcm FuzailBrcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look okay to me. Please get it checked with someone else too.

@StormLiangMS StormLiangMS merged commit de4506d into sonic-net:master Dec 14, 2022
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jan 1, 2023
Why I did it
The build project of s3ip framework

How I did it
How to verify it
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202211: #13213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants