Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mux] Integrate linkmgrd with swss logger #15392

Merged
merged 2 commits into from
Jun 19, 2023
Merged

[mux] Integrate linkmgrd with swss logger #15392

merged 2 commits into from
Jun 19, 2023

Conversation

lolyu
Copy link
Contributor

@lolyu lolyu commented Jun 8, 2023 •
edited
Loading

Why I did it

Integrate linkmgrd with swss logger.

$ swssloglevel -p
...
linkmgrd                      NOTICE
...
Work item tracking
  • Microsoft ADO (number only): 24214621

How I did it

How to verify it

Verified on testbed

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Tested branch (Please provide the tested image version)

  • 202205
  • master

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@lolyu
[mux] Integrate linkmgrd with swss logger
c4c4415 
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
@lolyu lolyu requested a review from lguohan as a code owner June 8, 2023 10:51
@lolyu lolyu requested review from yxieca and zjswhhh June 8, 2023 10:52
@zjswhhh
Copy link
Contributor

zjswhhh commented Jun 8, 2023

Hi @lolyu - can you add proper labels to linkmgrd PR#182 as well. It was only included in 202205.

zjswhhh
zjswhhh approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@zjswhhh zjswhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@lolyu
Copy link
Contributor Author

lolyu commented Jun 9, 2023 •
edited
Loading

Hi @lolyu - can you add proper labels to linkmgrd PR#182 as well. It was only included in 202205.

@zjswhhh Good catch, let's enable it for 202205 for now.

@azure-pipelines
Copy link

Command 'run

' is not supported by Azure Pipelines.


Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@yxieca
Copy link
Contributor

yxieca commented Jun 12, 2023

@lolyu can you check the test failures?

@lolyu
Copy link
Contributor Author

lolyu commented Jun 18, 2023

Hi @yxieca, the UT passed, please help review again!

@yxieca yxieca merged commit 7fd48eb into sonic-net:master Jun 19, 2023
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jun 19, 2023
@lolyu @mssonicbld
[mux] Integrate linkmgrd with swss logger (sonic-net#15392)
642ee78 
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202211: #15538

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jun 19, 2023
@lolyu @mssonicbld
[mux] Integrate linkmgrd with swss logger (sonic-net#15392)
33b6edd 
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202205: #15539

This was referenced Jun 19, 2023
Closed
Merged
mssonicbld added a commit that referenced this pull request Jun 20, 2023
@mssonicbld
[mux] Integrate linkmgrd with swss logger (#15392) (#15539)
d935f43
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jun 23, 2023
@lolyu @mssonicbld
[mux] Integrate linkmgrd with swss logger (sonic-net#15392)
676dea3 
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #15598

@mssonicbld mssonicbld mentioned this pull request Jun 23, 2023
Merged
10 tasks
mssonicbld pushed a commit that referenced this pull request Jun 26, 2023
@lolyu @mssonicbld
[mux] Integrate linkmgrd with swss logger (#15392)
664675c 
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
@mssonicbld
Copy link
Collaborator

@lolyu cherry pick PR didn't pass PR checker. Please check!!!
#15538

2 similar comments
@mssonicbld
Copy link
Collaborator

@lolyu cherry pick PR didn't pass PR checker. Please check!!!
#15538

@mssonicbld
Copy link
Collaborator

@lolyu cherry pick PR didn't pass PR checker. Please check!!!
#15538

@mssonicbld
Copy link
Collaborator

@lolyu cherry pick PR didn't pass PR checker. Please check!!! Auto cherry pick PR will be closed in 2 days.
#15538

1 similar comment
@mssonicbld
Copy link
Collaborator

@lolyu cherry pick PR didn't pass PR checker. Please check!!! Auto cherry pick PR will be closed in 2 days.
#15538

sonic-otn pushed a commit to sonic-otn/sonic-buildimage that referenced this pull request Sep 20, 2023
@lolyu @sonic-otn
[mux] Integrate linkmgrd with swss logger (sonic-net#15392)
22a3347 
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxieca yxieca yxieca approved these changes

@zjswhhh zjswhhh zjswhhh approved these changes

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

Assignees
No one assigned
Labels
Approved for 202211 Branch Approved for 202305 Branch Created PR to 202211 Branch Included in 202205 Branch Included in 202305 Branch Request for 202205 Branch Request for 202211 Branch Request for 202305 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lolyu @zjswhhh @yxieca @mssonicbld @StormLiangMS