Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minigraph] remove number of lanes check for changing speed from 400G to 100G and set speed setting before lane reconfiguration (#15721) #16453

Open
wants to merge 5 commits into
base: 202211
Choose a base branch
from

Commits on Sep 5, 2023

  1. [minigraph] remove number of lanes check for changing speed from 400G…

    … to 100G and set speed setting before lane reconfiguration (sonic-net#15721)
    
    8111 800G interface, split to 2x400G (each has 4 lanes) fails to change interface speed from 400G to 100G during deploy mg. In minigraph.xml, the interface speed configuration is good, but fails to generate the right value to config_db.json.
    
    In order to support this SKU the speed transitioning should support both 4 lanes and 8 lanes in the port_config.ini.
    
    Why I did it
    
    before this change for a 400G to 100G transition, in all cases except when lanes are 8, we would continue and the line
    ports.setdefault(port_name, {})['speed'] = port_speed_png[port_name]
    would not be executed, hence the default speed will never be set for a case and config_db will not be updated,
    where speed is transitioning from 400G to 100G or 40G, but lanes are not equal to 8.
    
    In order for those cases to pass where lanes are not specifically 8, we need the change
    
    Work item tracking
    24242657
    
    Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
    vdahiya12 committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    faf89eb View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. fix UT

    Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
    vdahiya12 committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    2774cc7 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. dummy commit

    Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
    vdahiya12 committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    dbc8c84 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. fix tests

    Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
    vdahiya12 committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    d0c44c3 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. test

    Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
    vdahiya12 committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    ae73d7f View commit details
    Browse the repository at this point in the history