Manually send SIGHUP to vtysh when the current session was disconnected #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Jun 19, 2018
| function cleanup | ||
| { | ||
| PID_FOR_HUP=$(docker exec -i bgp ps a | grep "vtysh $TTY" | awk '{print $1; }') | ||
| docker exec -i bgp kill -HUP $PID_FOR_HUP |
There was a problem hiding this comment.
Use 'pkill'? #Closed
lguohan
approved these changes
Jun 19, 2018
jleveque
approved these changes
Jun 19, 2018
qiluo-msft
approved these changes
Jun 19, 2018
5 tasks
wen587
added a commit
that referenced
this pull request
Oct 26, 2021
8ea834b [sonic_installer] Change sonic_installer check ASIC mismatch by platforms list (#1836) 9017d99 Fix the option missing in kernel config issue (#1888) 6595ad4 [mlag] fix log print sequence (#1730) e600e1c CLI command to load config in Yang format (#1781) 00948d0 Fix the target db version of portchannel-key test (#1842) 6412fea [sonic-package-manager] remove make_python_identifier (#1801) f738818 [sonic-package-manager] stop service explicitelly before uninstalling package (#1805) d8ee5e9 Remove exec from platform_reboot_plugin call to handle any hang issue. (#1879) 827fcee [chassis][routecheck]filter out the chassis internal interfaces (#1798) 4d732c6 [generic_config_updater] Logging (#1864) 25bb184 [config]: Add loopback interfaces to interface name checker (#1869) c950a55 Validate input of config mirror_session add (#1825) 9ab20fd [show][config] fix the muxcable commands for interface naming mode (#1862) 476b3a4 [multi-asic][cli][chassis-db] Avoid connecting to chassis db for cli commands executed from linecard (#1707)
taras-keryk
pushed a commit
to taras-keryk/sonic-buildimage
that referenced
this pull request
Apr 28, 2022
#### What I did It is not needed to make a CLI plugin name with valid python identifier. It is also possible that make_python_identifier will return same filename for two different packages. #### How I did it Removed make_python_identifier. #### How to verify it Install package with CLI plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
I added a logic to send SIGHUP to running vtysh in bgp container. Otherwise it will run in the container indefinitely long. This PR is fix for the previous #1792: which broke autocompletion in vtysh.
- How I did it
- How to verify it
Run vtysh and disconnect from the console. When you connect back, you'll not find any vtysh instances.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)