Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mitigate CVE-2018-5391 by sysctl #1948

Merged
merged 1 commit into from
Aug 19, 2018
Merged

Mitigate CVE-2018-5391 by sysctl #1948

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions build_debian.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,7 @@ check system $HOST
EOF

## Config sysctl
## TODO: ipfrag* are for mitigating CVE-2018-5391, remove after kernel upgraded
Copy link
Contributor

@jleveque jleveque Aug 18, 2018 •
edited by qiluo-msft
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest moving TODO line directly above the lines it refers to. #WontFix

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is technical difficulty to move because the block after "sudo augtool --autosave" is one huge command. Let me know if you have better idea.

In reply to: 211062664 [](ancestors = 211062664)

sudo mkdir -p $FILESYSTEM_ROOT/var/core
sudo augtool --autosave "
set /files/etc/sysctl.conf/kernel.core_pattern '|/usr/bin/coredump-compress %e %t %p'
Expand Down Expand Up @@ -309,6 +310,9 @@ set /files/etc/sysctl.conf/net.ipv6.conf.eth0.accept_ra_defrtr 0

set /files/etc/sysctl.conf/net.core.rmem_max 2097152
set /files/etc/sysctl.conf/net.core.wmem_max 2097152

set /files/etc/sysctl.conf/net.ipv4.ipfrag_high_thresh 262144
set /files/etc/sysctl.conf/net.ipv4.ipfrag_low_thresh 196608
" -r $FILESYSTEM_ROOT

## docker-py is needed by Ansible docker module
Expand Down