-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mellanox] Change NVIDIA SDK build to cmake method and Update SAI, SDK and FW Versions #19810
Open
dprital
wants to merge
5
commits into
sonic-net:master
Choose a base branch
from
dprital:master_migrate_sdk_build_to_cmake
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Mellanox] Change NVIDIA SDK build to cmake method and Update SAI, SDK and FW Versions #19810
dprital
wants to merge
5
commits into
sonic-net:master
from
dprital:master_migrate_sdk_build_to_cmake
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
stepanblyschak
approved these changes
Aug 7, 2024
dprital
changed the title
[Mellanox] Change NVIDIA SDK build to cmake method
[Mellanox] Change NVIDIA SDK build to cmake method and Update SAI, SDK and FW Versions
Sep 29, 2024
11 tasks
liat-grozovik
approved these changes
Sep 30, 2024
The SDK/SAI change LGTM. Need build team to review the cmake related change. @liushilongbuaa Can you please help review? |
@dprital I suggest separating the PR into two PRs, one for SAI/SDK change, and the other one for cmake related change. Please let me know how do you think. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Up to now, building Mellanox SDK debian packages was done by "autotools" method.
Lately, Mellanox SDK team added the support to build by "cmake" method.
The benefit of using "cmake" is with decrease time of SDK build as "cmake" make it faster then "auto build".
When moving to "cmake" method, all SDK debians:
will be replaced by single debian - sys_sdk.
In addition, Update:
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)