Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Change NVIDIA SDK build to cmake method and Update SAI, SDK and FW Versions #19810

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dprital
Copy link
Collaborator

@dprital dprital commented Aug 4, 2024

Why I did it

Up to now, building Mellanox SDK debian packages was done by "autotools" method.
Lately, Mellanox SDK team added the support to build by "cmake" method.
The benefit of using "cmake" is with decrease time of SDK build as "cmake" make it faster then "auto build".

When moving to "cmake" method, all SDK debians:

  • applibs
  • sx-complib
  • sx-example
  • sx-gen-utils
  • sx-scew
  • sxd-libs
  • python-sdk-api
  • sx-acl-helper
  • wjh-libs
  • sx-hash-calc
  • sx-obj-desc-lib
  • sxd-libs

will be replaced by single debian - sys_sdk.

In addition, Update:

  • SAI to version 2405.29.0.0
  • SDK/FW 4.7.1338/2014.1338
Work item tracking
  • Microsoft ADO (number only):

How I did it

  • Update cmake version on sonic slave dockers (bookworm and bullseye)
  • Change SDK Makefiles, delete all Makefiles of removed debians and add new Makefile for building sys_sdk.
  • Change sdk.mk and sdk.dep acordingly.
  • sx-kernel package was remain since it is consumed by the host as well and I didn't want to consume sys_sdk in host.

How to verify it

  • Enter syncd docker and verify the list of SDK packages are sx-kernel and sys-sdk only
  • Run regression tests and verify there is no degradation
  • Install the debian that include dbg-symbols and verify there are debug symbols by setting relevant breakpoints
  • Test the build time when using "cmake" for building SDK packages, compare to "auto build"

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@dprital
Copy link
Collaborator Author

dprital commented Aug 4, 2024

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dprital dprital changed the title [Mellanox] Change NVIDIA SDK build to cmake method [Mellanox] Change NVIDIA SDK build to cmake method and Update SAI, SDK and FW Versions Sep 29, 2024
@bingwang-ms
Copy link
Contributor

The SDK/SAI change LGTM. Need build team to review the cmake related change. @liushilongbuaa Can you please help review?

@bingwang-ms
Copy link
Contributor

@dprital I suggest separating the PR into two PRs, one for SAI/SDK change, and the other one for cmake related change. Please let me know how do you think. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants