Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[device][platform] Update Inventec platform porting to support stretch #2010

Merged
merged 5 commits into from
Sep 14, 2018
Merged

[device][platform] Update Inventec platform porting to support stretch #2010

merged 5 commits into from
Sep 14, 2018

Conversation

klhaung
Copy link
Contributor

@klhaung klhaung commented Sep 3, 2018

- What I did

  • add d6254qs d6556 platform porting
  • add sensor and status led support for d7032q28b d7254q28b d7264q28b d6254qs d6556
  • add qos support for d7032q28b d7254q28b
  • add service configuration files for d7032q28b d7254q28b d7264q28b d6254qs d6556
  • update platform drivers to support stretch

- How I did it

  • Follow Porting Guide to port D6254QS,D6556
  • Follow Porting Guide to configure sensors.conf for all inventec platform (D6254QS, D6556, D7032Q28B, D7054Q28B, D7264Q28B)
  • Add drivers and python scripts for monitoring system status and doing the corresponding actions for all inventec platform ((D6254QS, D6556, D7032Q28B, D7054Q28B, D7264Q28B))
  • Add one more transceiver in transceiver_monitor.py
  • Add service configuration for loading platform drivers and python scripts when the system started.

- How to verify it

  • Build image, install on device platform to make sure it is worked properly.

- Description for the changelog

[device][platform] d6254qs d6556 platform porting
[device][platform] sensor and status led support for d7032q28b d7254q28b d7264q28b d6254qs d6556
[device][platform] qos support for d7032q28b d7254q28b
[device][platform] service configuration files for d7032q28b d7254q28b d7264q28b d6254qs d6556

- A picture of a cute animal (not mandatory but encouraged)

@klhaung
[device][platform] d6254qs d6556 platform porting
a79d04b 
[device][platform] sensor and status led support for d7032q28b d7254q28b d7264q28b d6254qs d6556
[device][platform] qos support for d7032q28b d7254q28b
[device][platform] service configuration files for d7032q28b d7254q28b d7264q28b d6254qs d6556
@lguohan
Copy link
Collaborator

lguohan commented Sep 3, 2018

#include <linux/fs.h>

why do we need kernel thread here? it is better to put such logic into user space.

Refers to: platform/broadcom/sonic-platform-modules-inventec/d7032q28b/modules/inv_pthread.c:10 in a79d04b. [](commit_id = a79d04b, deletion_comment = False)

@lguohan
Copy link
Collaborator

lguohan commented Sep 3, 2018

what are the .pkg files for d6556 platform? we do not allow binary file to be check-in. if we need to include these files in the SAI package, we need to work with broadcom on this.

@lguohan
Copy link
Collaborator

lguohan commented Sep 3, 2018

what is linkscan_led_fw.bin, we do not allow binary file to be check-in

@lguohan
Copy link
Collaborator

lguohan commented Sep 3, 2018

what is custom_led.bin, we do not allow binary file to be checked-in.

@lguohan
Copy link
Collaborator

lguohan commented Sep 4, 2018

Auto detecting the transceiver and set the correct if_type value

set if_type is support by SAI, we can expose it as a SWSS service via APP DB. We do not need to set it via the bcmcmd, it is very hacky.

Also, this transceiver_monitor is similiar to xrcvd we have recently introduced as platform daemon, it is better to incorporate the functionality into xrcvd.

Refers to: platform/broadcom/sonic-platform-modules-inventec/common/utils/transceiver_monitor.py:12 in a79d04b. [](commit_id = a79d04b, deletion_comment = False)

@lguohan
Copy link
Collaborator

lguohan commented Sep 4, 2018

for transceiver.c, we have sfp/qsfp parser in the user space, why do we need them in the kernel space?

lguohan
lguohan reviewed Sep 4, 2018
View reviewed changes
platform/broadcom/sonic-platform-modules-inventec/d6556/modules/inv_platform.c Outdated
int ret = 0;
int i,j,k;

//printk("%s \n", __func__);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the comment

@jleveque jleveque changed the title [device][platform] update inventect platform porting to support stretch [device][platform] Update Inventec platform porting to support stretch Sep 4, 2018
@klhaung
Copy link
Contributor Author

klhaung commented Sep 7, 2018

Thanks for the review. Please consider to merge the fix into SONiC master branch so that we can base on the new code base for next version. Thanks.

@lguohan lguohan merged commit 6f496bd into sonic-net:master Sep 14, 2018
@stanepc1 stanepc1 mentioned this pull request Sep 26, 2018
Closed
pollyhsu2git referenced this pull request Dec 10, 2018
@yxieca
[bcm sai] upgrade to Broadcom SAI 3.3 GA release
1812d6c 
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
stepanblyschak added a commit to stepanblyschak/sonic-buildimage that referenced this pull request Nov 11, 2021
@stepanblyschak
[sonic-swss] update submodule
198d136 
```
5f8ebfa (HEAD, origin/master, origin/HEAD, master) [AclOrch] move ACL counters to flex counter infrastructure (sonic-net#1943)
8119ec0 [bfdorch] Orchagent support hardware BFD (sonic-net#1883)
15074ac [sonic-swss]:enable unconfiguring PFC on last TC on a port (sonic-net#1962)
05c7c05 [Mux orch] set default as standby, change mux orch priority (sonic-net#2010)
fe5b2a9 [pytest]: Ignore errors deleting host ifs (sonic-net#2005)
70da9af [ci]: use native arm64 and armhf pool (sonic-net#2013)
e14a071 [qos] Add EXP to TC map support (sonic-net#1954)
c91a7f2 [switchorch] Implement VXLAN src port range feature  (sonic-net#1959)
b20f0f4 Gcov for swss daemon (sonic-net#1737)
01c243a [CRM][MPLS] Fix the mpls nexthop CRM attribute (sonic-net#2008)
8448a60 [vs tests]Migrating sonic-swss tests to use hwsku instead of fakeplatform (sonic-net#1978)
faa26db Fix random failure in PR/CI build. (sonic-net#2006)
e03edb6 Allow interface type value none (sonic-net#1991)
71b9650 [orchagent] Fix group name of port-buffer-drop in flexcounterorch.cpp (sonic-net#1967)
facdef5 [VS test] Skip flaky virtual chassis test (sonic-net#2004)
8261c1f [pytest]: Increase timeout when checking services (sonic-net#2000)
67278be [teammgrd]: Handle LAGs cleanup gracefully on Warm/Fast reboot. (sonic-net#1934)
e92c1df Enable FEC statistics collection for Ethernet ports (sonic-net#1994)
9f30ca1 VxLAN Tunnel Counters and Rates implementation (sonic-net#1859)
ac3103a Add missing neighbor resolution for MPLS route programming (sonic-net#1968)
bfba0ad [vlanmgr]Fix for STATE_DB port check logic (sonic-net#1980)
9ef2ba4 [vlanmgr]: Update VLAN removal code to work with 5.10 kernel and newer iproute2 versions (sonic-net#1970)
41fb26c [Mux orch] Handle setting unknown mux state (sonic-net#1984)
ac09bde [azp]: Increase timeout for VS tests (sonic-net#1988)
da8a43e [pytest]: Check if appl DB exists before deleting (sonic-net#1983)
553d75a [tunnel decap] Change tunnel orch order (sonic-net#1977)
7444e96 [macsecmgr]: Add rekey period in macsec mgr (sonic-net#1958)
d95823d [Buffermgr]Graceful handling of buffer model change (sonic-net#1956)
b0aa6a0 EVPN VxLAN enhancement to support P2MP tunnel based programming for Layer2 extension (sonic-net#1858)
85bdf54 Fix the option missing in kernel config issue (sonic-net#1973)
6b15584 Orchagent validates mirror session queue parameter against maximum value from SAI (sonic-net#1957)
fc9ffb9 [copp] Add ISIS, LDP and micro-BFD trap types to CoPP manager (sonic-net#1890)
452cbc1 [macsecorch]: Add IPG adjusting for MACsec gearbox model (sonic-net#1925)
```

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
stepanblyschak added a commit to stepanblyschak/sonic-buildimage that referenced this pull request Nov 11, 2021
@stepanblyschak
[sonic-swss] update submodule
aef49e3 
```
5f8ebfa (HEAD, origin/master, origin/HEAD, master) [AclOrch] move ACL counters to flex counter infrastructure (sonic-net#1943)
8119ec0 [bfdorch] Orchagent support hardware BFD (sonic-net#1883)
15074ac [sonic-swss]:enable unconfiguring PFC on last TC on a port (sonic-net#1962)
05c7c05 [Mux orch] set default as standby, change mux orch priority (sonic-net#2010)
fe5b2a9 [pytest]: Ignore errors deleting host ifs (sonic-net#2005)
70da9af [ci]: use native arm64 and armhf pool (sonic-net#2013)
e14a071 [qos] Add EXP to TC map support (sonic-net#1954)
c91a7f2 [switchorch] Implement VXLAN src port range feature  (sonic-net#1959)
b20f0f4 Gcov for swss daemon (sonic-net#1737)
01c243a [CRM][MPLS] Fix the mpls nexthop CRM attribute (sonic-net#2008)
```

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
lguohan pushed a commit that referenced this pull request Nov 15, 2021
@stepanblyschak
[sonic-swss] update submodule (#9232)
0e057a4 
```
5f8ebfa (HEAD, origin/master, origin/HEAD, master) [AclOrch] move ACL counters to flex counter infrastructure (#1943)
8119ec0 [bfdorch] Orchagent support hardware BFD (#1883)
15074ac [sonic-swss]:enable unconfiguring PFC on last TC on a port (#1962)
05c7c05 [Mux orch] set default as standby, change mux orch priority (#2010)
fe5b2a9 [pytest]: Ignore errors deleting host ifs (#2005)
70da9af [ci]: use native arm64 and armhf pool (#2013)
e14a071 [qos] Add EXP to TC map support (#1954)
c91a7f2 [switchorch] Implement VXLAN src port range feature  (#1959)
b20f0f4 Gcov for swss daemon (#1737)
01c243a [CRM][MPLS] Fix the mpls nexthop CRM attribute (#2008)
```

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022
@prsunny
[Mux orch] set default as standby, change mux orch priority (sonic-ne…
05c7c05 
…t#2010)

*Set default status for each mux port to standby state during init.
*Change mux orch priority to process entries before neighbor orch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan left review comments

Assignees
No one assigned
Labels
Enhancement ➕ Platform: Inventec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klhaung @lguohan @jleveque