[knet driver] don't unload knet drivers during shutdown #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenggen-xu
reviewed
Dec 7, 2018
platform/broadcom/saibcm-modules/debian/opennsl-modules-4.9.0-7-amd64.init
Outdated
Show resolved
Hide resolved
platform/broadcom/saibcm-modules/debian/opennsl-modules-4.9.0-7-amd64.init
Outdated
Show resolved
Hide resolved
knet driver unload takes about 30 seconds to remove netdevs. This cuts into our warm reboot time budget. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
zhenggen-xu
approved these changes
Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
knet driver unload takes about 30 seconds to remove netdevs. This cut
into our warm reboot time budget.
therefore, don't unload knet drivers during shutdown
- How to verify it
verified with warm reboot test.