Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[platform-celestica]: Add new fancontrol service for haliburton device #2736

Merged
merged 1 commit into from Apr 11, 2019
Merged

[platform-celestica]: Add new fancontrol service for haliburton device #2736

merged 1 commit into from Apr 11, 2019

Conversation

mudsut4ke
Copy link
Contributor

- What I did

  • Upgrade fancontrol daemon of Haliburton device to support the temperature hysteresis and difference config for each unit fan direction type (B2F/F2B)

- How I did it

- How to verify it

  • Run thermal test

Signed-off-by: Wirut Getbamrung wgetbumr@celestica.com

@renukamanavalan renukamanavalan self-requested a review April 4, 2019 15:37
@renukamanavalan
Copy link
Contributor

Can you please post the results and as well the command to run the tests?

@mudsut4ke
Copy link
Contributor Author

mudsut4ke commented Apr 8, 2019 •
edited
Loading

@renukamanavalan

For fan speed control validation test, thermal test ambient range from 20C–45C–20C to complete 1 cycle, 5C each step, waiting the temperature reach stable state and change to next step, record all fan speed data from sensors command in the duration.

Result: Fan speed curve based on FSC algorithm (F2B)

F2B

Result: Fan speed curve based on FSC algorithm (B2F)

B2F

Conclution: The actual fan speed curve match fan speed control algorithm setting and all components temperature is under the required operating conditions.

@renukamanavalan
Copy link
Contributor

Is there a automated way to test this script ?

Reason: We would like to test this locally, when we get the updated image

@mudsut4ke
Copy link
Contributor Author

@renukamanavalan , In this version we didn't prepare the way for automate test,
We just record fan speed during thermal change on test chamber.

@lguohan lguohan merged commit 4fcb332 into sonic-net:master Apr 11, 2019
@mudsut4ke mudsut4ke deleted the master-e1031-new-fsc branch October 24, 2019 09:49
yxieca pushed a commit that referenced this pull request May 5, 2023
@mssonicbld
[submodule] Update submodule sonic-swss to the latest HEAD automatica…
441b5ad 
…lly (#14942)

src/sonic-swss

* f977724 - (HEAD -> 202205, origin/202205) [bugfix] vnet ping missing with secondary endpoints empty in priority routes. (#2736) (2 hours ago) [siqbal1986]
* a723a99 - Fix orchagent missing request when logrotate happens. (#2712) (2 hours ago) [mint570]
* 24db6da - Handle duplicate routes in a graceful manner (#2688) (2 hours ago) [prabhataravind]
@siqbal1986 siqbal1986 mentioned this pull request May 11, 2023
Merged
10 tasks
prsunny pushed a commit that referenced this pull request May 18, 2023
@siqbal1986
[202012] submodule update sonic-swss. (#15023)
7502634 
Updated for commit:

f141880 - 2023-04-26 : [bugfix] vnet ping missing with secondary endpoints empty in priority routes. (#2736) (#2747) [siqbal1986]
mihirpat1 pushed a commit to mihirpat1/sonic-buildimage that referenced this pull request Jun 14, 2023
@siqbal1986
[bugfix] vnet ping missing with secondary endpoints empty in priority…
5bedf4e 
… routes. (sonic-net#2736)

Adding a priority vnet route without secondary endpoints with
custom monitoring does not result in vnet ping session creation.
This change fixes that and adds a test.
Signed-off-by: siqbal1486 <shahzad.iqbal@microsoft.com>
qiluo-msft pushed a commit that referenced this pull request Aug 10, 2023
@mssonicbld
[submodule] Update submodule sonic-swss to the latest HEAD automatica…
43f6281 
…lly (#14865)

#### Why I did it
src/sonic-swss
```
* f141880 - (HEAD -> 202012, origin/202012) [bugfix] vnet ping missing with secondary endpoints empty in priority routes. (#2736) (#2747) (3 weeks ago) [siqbal1986]
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleveque jleveque jleveque approved these changes

@renukamanavalan renukamanavalan renukamanavalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mudsut4ke @renukamanavalan @jleveque @lguohan