Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bgp quagga] increase BGP graceful restart timeout to 240 seconds #2754

Merged
merged 1 commit into from
Apr 11, 2019
Merged

[bgp quagga] increase BGP graceful restart timeout to 240 seconds #2754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dockers/docker-fpm-quagga/bgpd.conf.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ router bgp {{ DEVICE_METADATA['localhost']['bgp_asn'] }}
bgp log-neighbor-changes
bgp bestpath as-path multipath-relax
no bgp default ipv4-unicast
bgp graceful-restart restart-time 180
bgp graceful-restart restart-time 240
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per your description of the PR, it seems we are accommodating the value for some particular HW. I would think it is better to make it as a configurable item in minigraph/configDB. If not configured, the default is still 180, but on some particular platforms, we can increase the timer value.

bgp graceful-restart
{% for (name, prefix) in LOOPBACK_INTERFACE %}
{% if prefix | ipv4 and name == 'Loopback0' %}
Expand Down
2 changes: 1 addition & 1 deletion src/sonic-config-engine/tests/sample_output/bgpd_quagga.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ router bgp 65100
bgp log-neighbor-changes
bgp bestpath as-path multipath-relax
no bgp default ipv4-unicast
bgp graceful-restart restart-time 180
bgp graceful-restart restart-time 240
bgp graceful-restart
bgp router-id 10.1.0.32
network 10.1.0.32/32
Expand Down