[teamd service] start teamd service after swss #2829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SWSS clears DB tables, if teamd is not started after swss, there is a race condition that swss might clear vital teamd information. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
jleveque
approved these changes
Apr 26, 2019
prsunny
approved these changes
Apr 26, 2019
lguohan
approved these changes
Apr 26, 2019
|
Then what is the root cause to the problem mentioned in #2733 ? |
|
@jipanyang That still needs investigation. That issue was caused by teamd after swss, which still should work. But let's get teamd after syncd in to solve the timing issue first. |
yxieca
added a commit
that referenced
this pull request
Apr 26, 2019
SWSS clears DB tables, if teamd is not started after swss, there is a race condition that swss might clear vital teamd information. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
MichelMoriniaux
pushed a commit
to criteo-forks/sonic-buildimage
that referenced
this pull request
May 28, 2019
SWSS clears DB tables, if teamd is not started after swss, there is a race condition that swss might clear vital teamd information. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
SWSS clears DB tables, if teamd is not started after swss, there is a
race condition that swss might clear vital teamd information.
Signed-off-by: Ying Xie ying.xie@microsoft.com
- How to verify it
continuous warm reboot, reboot.