[teamd] fix lacp fallback mode breakage in teamd v1.28 #3572
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #951
In teamd v1.28, the port can only be enabled if sync bit is set
in recveived LACPDU from partner by the following commit
"teamd: lacp: update port state according to partner's sync bit"
(jpirko/libteam@54f137c)
However, lacp fallback feature needs to enable port even if partner
LACPDU is not received within a given period and fallback cfg is enabled.
To fix the lacp fallback breakage, we have to bypass the sync bit
check in lacp fallback mode.
Signed-off-by: Haiyang Zheng haiyang.z@alibaba-inc.com
- What I did
Fix lacp fallback mode breakage in teamd v 1.28
- How I did it
bypass the sync bit check in lacp fallback mode, which is introduced in teamd v1.28 and later
- How to verify it
verify that the port can enter and exit lacp fallback mode with the change as expected.
And the change passed the following test case
https://github.com/Azure/sonic-mgmt/pull/379/files
- Description for the changelog
[teamd] fix lacp fallback mode breakage in teamd v1.28
- A picture of a cute animal (not mandatory but encouraged)