libyang 1.0.73 #3710
Merged
libyang 1.0.73 #3710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- build libyang1.0.73 debian pacakge from libyang github source
- build libyang python2 and python3 debian packages
|
|
|
retest this please |
|
@li-pingmao Can you please put in description why do we need this change? |
| set(LIBYANG_SOVERSION_FULL ${LIBYANG_MAJOR_SOVERSION}.${LIBYANG_MINOR_SOVERSION}.${LIBYANG_MICRO_SOVERSION}) | ||
| set(LIBYANG_SOVERSION ${LIBYANG_MAJOR_SOVERSION}) | ||
|
|
||
| +set(CMAKE_INSTALL_PREFIX /usr) |
There was a problem hiding this comment.
I think it'd better to use cmake -DCMAKE_INSTALL_PREFIX=/usr instead
|
The main reasons this change is needed:
|
pavel-shirshov
approved these changes
Nov 7, 2019
zhenggen-xu
pushed a commit
to zhenggen-xu/sonic-buildimage
that referenced
this pull request
Jan 10, 2020
- build libyang1.0.73 debian pacakge from libyang github source
- build libyang python2 and python3 debian packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reasons this change:
We need libyang python debian packages. libyang python2 debian package needed by sonic-utility CLI for dynamic port breakout.
Build libyang from source to pick up bug fixes
- What I did
- Build libyang version 1.0.73 from libyang github source
- Build libyang python2 and python3 debian packages
- How I did it
- How to verify it
libyang debian packages built:
target/debs/stretch/libyang_1.0.73_amd64.deb
target/debs/stretch/libyang-cpp_1.0.73_amd64.deb
target/debs/stretch/libyang-dbg_1.0.73_amd64.deb
target/debs/stretch/libyang-dev_1.0.73_amd64.deb
target/debs/stretch/python2-yang_1.0.73_amd64.deb
target/debs/stretch/python3-yang_1.0.73_amd64.deb
libyang python yang.py is installed in both python2 and python3 after installing the packages:
./usr/lib/python2.7/dist-packages/yang.py
./usr/lib/python3/dist-packages/yang.py
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)