DellEMC: optoe driver support in S6000,S6100,Z9100 #3747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
approved these changes
Nov 13, 2019
lguohan
approved these changes
Nov 14, 2019
zhenggen-xu
pushed a commit
to zhenggen-xu/sonic-buildimage
that referenced
this pull request
Jan 10, 2020
- optoe driver truncates invalid pages(ff) but sff driver doesn't truncate.so,the DOM related calculation made by sff8436 driver will show incorrect data. - Few optics doesn't support DOM. - SFP plugins currently returns None for unreadable pages and this'd throw the below mentioned error in sfpshow eeprom --dom.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Description for the changelog
root@sonic:/sys/class/i2c-adapter/i2c-32/32-0050# sfpshow eeprom -p Ethernet1 -d
Traceback (most recent call last):
File "/usr/bin/sfpshow", line 358, in
cli()
File "/usr/lib/python2.7/dist-packages/click/core.py", line 722, in call
return self.main(*args, **kwargs)
File "/usr/lib/python2.7/dist-packages/click/core.py", line 697, in main
rv = self.invoke(ctx)
File "/usr/lib/python2.7/dist-packages/click/core.py", line 1066, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/lib/python2.7/dist-packages/click/core.py", line 895, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/lib/python2.7/dist-packages/click/core.py", line 535, in invoke
return callback(*args, **kwargs)
File "/usr/bin/sfpshow", line 348, in eeprom
sfp.display_eeprom(port, dump_dom)
File "/usr/bin/sfpshow", line 293, in display_eeprom
out_put = self.convert_interface_sfp_info_to_cli_output_string(self.sdb, interfacename, dump_dom)
File "/usr/bin/sfpshow", line 282, in convert_interface_sfp_info_to_cli_output_string
dom_output = self.convert_dom_to_output_string(sfp_type, dom_info_dict)
File "/usr/bin/sfpshow", line 186, in convert_dom_to_output_string
channel_threshold_align)
File "/usr/bin/sfpshow", line 146, in format_dict_value_to_string
if dom_info_dict is not None and dom_info_dict[key] != 'N/A':
KeyError: 'rxpowerhighalarm'
To fix it,return dictionary itself with 'N/A' values as it's been handled in sfpshow script.
Changed the wrong DOM offset used in Z9264f
UT logs:
S6000_UT.txt
s6100_UT.txt
Z9100_UT.txt
Z9264f_UT.txt