Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Extend mellanox platform API to report SFP error event #4365

Merged
merged 6 commits into from
Apr 14, 2020
Merged

[Mellanox] Extend mellanox platform API to report SFP error event #4365

merged 6 commits into from
Apr 14, 2020

Conversation

keboliu
Copy link
Collaborator

@keboliu keboliu commented Apr 3, 2020

- What I did
Extend SFP event API to report SFP error to the upper layer app.

- How I did it
handle SFP event which reported from SDK, log all the detail error type and pass the error event that will block EEPROM accessing to the upper layer.

- How to verify it
test on Mellanox platform

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

This PR has a dependency on sonic-net/sonic-platform-common#80

@qiluo-msft
Copy link
Collaborator

qiluo-msft commented Apr 3, 2020

            if not port_dict == {}:

If not bool(port_dict): #Closed


Refers to: platform/mellanox/mlnx-platform-api/sonic_platform/chassis.py:451 in 3cef25c. [](commit_id = 3cef25c, deletion_comment = False)

@qiluo-msft
Copy link
Collaborator

qiluo-msft commented Apr 3, 2020

        return True

return found != 0; #Closed


Refers to: platform/mellanox/mlnx-platform-api/sonic_platform/sfp_event.py:268 in 3cef25c. [](commit_id = 3cef25c, deletion_comment = False)

@keboliu
Copy link
Collaborator Author

keboliu commented Apr 10, 2020

        return True

return found != 0;

Refers to: platform/mellanox/mlnx-platform-api/sonic_platform/sfp_event.py:268 in 3cef25c. [](commit_id = 3cef25c, deletion_comment = False)

revised, thanks.

@keboliu
Copy link
Collaborator Author

keboliu commented Apr 10, 2020

            if not port_dict == {}:

If not bool(port_dict):

Refers to: platform/mellanox/mlnx-platform-api/sonic_platform/chassis.py:451 in 3cef25c. [](commit_id = 3cef25c, deletion_comment = False)

revised, thanks.

@liat-grozovik
Copy link
Collaborator

retest mellanox please

@jleveque jleveque merged commit cfa112a into sonic-net:master Apr 14, 2020
abdosi pushed a commit that referenced this pull request Apr 15, 2020
)

* extend mellanox platform API to report SFP error event
* remove unnecessary loop code
* install enum34 to pmon to support using Enum
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 24, 2020
…nic-net#4365)

* extend mellanox platform API to report SFP error event
* remove unnecessary loop code
* install enum34 to pmon to support using Enum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants