Fix authentication in restapi #4383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
reviewed
Apr 7, 2020
lguohan
reviewed
Apr 7, 2020
lguohan
reviewed
Apr 7, 2020
lguohan
reviewed
Apr 7, 2020
lguohan
reviewed
Apr 7, 2020
jleveque
suggested changes
Apr 8, 2020
|
retest vsimage please |
1. Check for cert path from config DB 2. Add critical process monitoring
jleveque
suggested changes
Apr 10, 2020
Adding new lines
|
retest vsimage please |
1 similar comment
|
retest vsimage please |
lguohan
approved these changes
Apr 14, 2020
jleveque
approved these changes
Apr 14, 2020
abdosi
pushed a commit
that referenced
this pull request
Apr 15, 2020
- enabling http/https endpoint and mounting the certificates directory - updating the sonic-restapi submodule
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 24, 2020
- enabling http/https endpoint and mounting the certificates directory - updating the sonic-restapi submodule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fix authentication issues in restapi server
- How I did it
enabling https endpoint and mounting the certificates directory
Also updating the sonic-restapi submodule
- How to verify it
- Description for the changelog
Enable https endpoint for restapi server
- A picture of a cute animal (not mandatory but encouraged)