Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DellEMC] s5232f console and sfputil fix #4453

Merged
merged 3 commits into from
Apr 23, 2020
Merged

[DellEMC] s5232f console and sfputil fix #4453

merged 3 commits into from
Apr 23, 2020

Conversation

srideepDell
Copy link
Contributor

@srideepDell srideepDell commented Apr 21, 2020 •
edited
Loading

Remove hardcoding 115K baudrate for console
Sync sfputil.py from master to 201911 branch

- What I did

Remove hardcoding 115K baudrate for console
Enhance sfputil api as per spec

- How I did it
Modifying platform related files for S5232 under device folder.

- How to verify it
Did verify on S5232 platform

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@srideepDell
[DellEMC] s5232f console and sfputil fix
6a8db7e 
Remove hardcoding 115K baudrate for console
Enhance sfputil api as per spec
@srideepDell
Copy link
Contributor Author

srideepDell commented Apr 21, 2020 •
edited
Loading

Logs
System booted on 9600 console
SFP logs

sfputil show presence | more
Port Presence

Ethernet0 Present
Ethernet4 Present
Ethernet8 Present
Ethernet12 Present
Ethernet16 Not present

show interfaces transceiver eeprom | more
Ethernet0: SFP EEPROM detected
Connector: MPOx12
Encoding: 64B66B
Extended Identifier: Power Class 4(3.5W max), CDR present in Rx Tx
Extended RateSelect Compliance: QSFP+ Rate Select Version 1
Identifier: QSFP28 or later
Length Cable Assembly(m): 150
Nominal Bit Rate(100Mbs): 255
Specification compliance:
Vendor Date Code(YYYY-MM-DD Lot): 2019-04-25
Vendor Name: DELL
Vendor OUI: 00-17-6a
Vendor PN: 14NV5
Vendor Rev: A0
Vendor SN: CN07919294P05AM

@srideepDell srideepDell marked this pull request as ready for review April 21, 2020 09:29
@lgtm-com
Copy link

lgtm-com bot commented Apr 21, 2020

This pull request introduces 1 alert when merging 230995c into 898f878 - view on LGTM.com

new alerts:

  • 1 for Unused import

@srideepDell
Copy link
Contributor Author

retest broadcom please

@lguohan lguohan merged commit 773e83b into sonic-net:201911 Apr 23, 2020
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 24, 2020
@srideepDell @tiantianlv
[DellEMC] s5232f console and sfputil fix (sonic-net#4453)
d4c9daf 
* [DellEMC] s5232f console and sfputil fix
Remove hardcoding 115K baudrate for console
Enhance sfputil api as per spec
@srideepDell srideepDell deleted the 201911_s5232_fixes branch April 27, 2020 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srideepDell @lguohan