Fix for BGP peer not coming up even after doing config BGP startup all #4547
Conversation
dockers/docker-fpm-frr/bgpcfgd
Outdated
| @@ -744,6 +744,7 @@ class BGPPeerMgrBase(Manager): | |||
| :param data: the data associated with the change | |||
| """ | |||
| vrf, nbr = self.split_key(key) | |||
| key = (vrf, nbr) | |||
There was a problem hiding this comment.
Seems odd to redefine key here. Maybe just change the following line to if (vrf, nbr) not in self.peers:. Will this suffice?
There was a problem hiding this comment.
Agree. It is better to use different name.
key in the param list is a string
key which is defined here is a tuple of two strings.
There was a problem hiding this comment.
@pavel-shirshov @JLevesque84 updated to use "peer_key"
There was a problem hiding this comment.
@abdosi; FYI, you tagged somebody that isn't me, but has a similar username :)
dockers/docker-fpm-frr/bgpcfgd
Outdated
| @@ -744,6 +744,7 @@ class BGPPeerMgrBase(Manager): | |||
| :param data: the data associated with the change | |||
| """ | |||
| vrf, nbr = self.split_key(key) | |||
| key = (vrf, nbr) | |||
There was a problem hiding this comment.
Agree. It is better to use different name.
key in the param list is a string
key which is defined here is a tuple of two strings.
dockers/docker-fpm-frr/bgpcfgd
Outdated
| @@ -871,6 +872,7 @@ class BGPPeerMgrBase(Manager): | |||
| :param key: key of the neighbor | |||
| """ | |||
| vrf, nbr = self.split_key(key) | |||
| key = (vrf, nbr) | |||
There was a problem hiding this comment.
Better to use different name here.
There was a problem hiding this comment.
@pavel-shirshov updated to use "peer_key"
|
We notice bgp sessions not up after issuing 'sudo config reload -y' on 201911. Does it fix this issue as well? |
Issue was key not correct to look into self.peer. It need to be tuple of (vrf,nbr). Updated for both add/del
|
@wendani, do you have issue created? |
|
Not yet. Need further confirmation on a clean, latest 201911. |
|
Lol.. what is this?
…Sent from my iPhone
On May 6, 2020, at 3:58 PM, Joe LeVeque ***@***.***> wrote:
@jleveque commented on this pull request.
In dockers/docker-fpm-frr/bgpcfgd:
> @@ -744,6 +744,7 @@ class BGPPeerMgrBase(Manager):
:param data: the data associated with the change
"""
vrf, nbr = self.split_key(key)
+ key = (vrf, nbr)
@abdosi; FYI, you tagged somebody that isn't me, but has a similar username :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
oops.. sorry. meant for other Joe |
…up all (#4547) Issue was key not correct to look into self.peer. It need to be tuple of (vrf,nbr). Updated for both add/del
- Why I did it
Fix for BGP peer not coming up even after doing config BGP startup all. Issue was key not correct to lookup into self.peer. Because of that we always used to go for add_peer and admin status update never happened,
- How I did it
Made key tuple of (vrf,nbr). Updated for both add/del peer case
- How to verify it
Manually Verified on T1-topology setup using show ip bgp summary