[Mellanox] Optimize SFP Platform API implementation #5476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject share one SDK handle instead each object have their own
|
This pull request introduces 1 alert when merging fb783de into e3f8159 - view on LGTM.com new alerts:
|
stephenxs
previously approved these changes
Sep 29, 2020
|
retest this please |
jleveque
reviewed
Oct 3, 2020
|
retest mellanox please |
3 similar comments
|
retest mellanox please |
|
retest mellanox please |
|
retest mellanox please |
keboliu
force-pushed
the
optimize-sfp-api
branch
from
a94a583
to
7006fd1
Compare
jleveque
approved these changes
Oct 19, 2020
abdosi
pushed a commit
that referenced
this pull request
Oct 21, 2020
Each SFP object inside Chassis will open an SDK client, this is not necessary and SDK client can be shared between SFP objects.
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
Each SFP object inside Chassis will open an SDK client, this is not necessary and SDK client can be shared between SFP objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
Each SFP object inside Chassis will open an SDK client, this is not necessary and SDK client can be shared between SFP objects.
- How I did it
Open one SDK client in Chassis init phase, pass this SDK client handle to all the SFP objects when init them.
Remove SDK client open/close code from the SFP object init/delete process.
- How to verify it
Verify current pmon daemons work well with these change.
Call related platform API and test the result.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)