Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ENABLE_SYNCD_RPC option #642

Merged
merged 1 commit into from
May 30, 2017
Merged

Add ENABLE_SYNCD_RPC option #642

merged 1 commit into from
May 30, 2017

Conversation

marian-pritsak
Copy link
Collaborator

Under rules/config now there's additional configuration option
ENABLE_SYNCD_RPC that allows building SONIC installer with
docker-syncd-*-rpc for evaluation purposes.

Signed-off-by: marian-pritsak marianp@mellanox.com

@msftclas
Copy link

@marian-pritsak, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@@ -1,6 +1,6 @@
# sonic broadcom one image installer

SONIC_ONE_ABOOT_IMAGE = sonic-aboot-broadcom.swi
SONIC_ONE_ABOOT_IMAGE = sonic-aboot-broadcom$(if $(ENABLE_SYNCD_RPC),-rpc).swi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for simplicity, I suggest leave appending -rpc to the user. The build system still builds the same file. sonic-aboot-broadcom.swi, user will then rename the file properly.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Collaborator

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not need to append -rpc in the image name. leave to the user to rename it.

Under rules/config now there's additional configuration option
ENABLE_SYNCD_RPC that allows building SONIC installer with
docker-syncd-*-rpc for evaluation purposes.

Signed-off-by: marian-pritsak <marianp@mellanox.com>
@marian-pritsak marian-pritsak changed the title Add sonic-*-rpc.bin target Add ENABLE_SYNCD_RPC option May 30, 2017
@lguohan lguohan merged commit 520fff5 into sonic-net:master May 30, 2017
dgsudharsan pushed a commit to dgsudharsan/sonic-buildimage that referenced this pull request Nov 6, 2019
[warm/fast reboot] continue executing when killing docker failed (sonic-net#713)
[Ying Xie]
[neighbor_advertiser]: Add sleep in setting mirror session and ACL
rules(sonic-net#714)[Shuotian Cheng]
[config]: Flush the neighbor table when removing the router
interface(sonic-net#606) [Shuotian Cheng]
Add a generic configlet application script (sonic-net#716) [Renuka Manavalan]
Management vrf snmp cli support (sonic-net#472) [Harish Venkatraman]
show subinterfaces status (sonic-net#642) [Wenda Ni]
sonic-utilities: Add support for sFlow (sonic-net#592) [Garrick He]
lguohan pushed a commit that referenced this pull request Nov 6, 2019
- [warm/fast reboot] continue executing when killing docker failed (#713) [Ying Xie]
- [neighbor_advertiser]: Add sleep in setting mirror session and ACL rules(#714)[Shuotian Cheng]
- [config]: Flush the neighbor table when removing the router interface(#606) [Shuotian Cheng]
- Add a generic configlet application script (#716) [Renuka Manavalan]
- Management vrf snmp cli support (#472) [Harish Venkatraman]
- show subinterfaces status (#642) [Wenda Ni]
- sonic-utilities: Add support for sFlow (#592) [Garrick He]
zhenggen-xu pushed a commit to zhenggen-xu/sonic-buildimage that referenced this pull request Jan 10, 2020
- [warm/fast reboot] continue executing when killing docker failed (sonic-net#713) [Ying Xie]
- [neighbor_advertiser]: Add sleep in setting mirror session and ACL rules(sonic-net#714)[Shuotian Cheng]
- [config]: Flush the neighbor table when removing the router interface(sonic-net#606) [Shuotian Cheng]
- Add a generic configlet application script (sonic-net#716) [Renuka Manavalan]
- Management vrf snmp cli support (sonic-net#472) [Harish Venkatraman]
- show subinterfaces status (sonic-net#642) [Wenda Ni]
- sonic-utilities: Add support for sFlow (sonic-net#592) [Garrick He]
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020
Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 10, 2021
* Add sub port interface to intfutil status

Signed-off-by: Wenda Ni <wenni@microsoft.com>

* Format change

Signed-off-by: Wenda Ni <wenni@microsoft.com>

* Hook 'intfutil status' with show subinterfaces status

Signed-off-by: Wenda Ni <wenni@microsoft.com>

* Add 'intfutil status subport' to show only the status of sub port interfaces

Signed-off-by: Wenda Ni <wenni@microsoft.com>

* Hook 'intfutil status subport' with 'show subinterfaces status'

Signed-off-by: Wenda Ni <wenni@microsoft.com>

* Support intfutil status <sub_port_intf_name>

Signed-off-by: Wenda Ni <wenni@microsoft.com>

* Add alias naming mode support

Signed-off-by: Wenda Ni <wenni@microsoft.com>

* Address comments

Signed-off-by: Wenda Ni <wenni@microsoft.com>

* Address comment: concatenate command line, and validate input

Signed-off-by: Wenda Ni <wenni@microsoft.com>

* Address comment: keep show interface status intact

Signed-off-by: Wenda Ni <wenni@microsoft.com>

* Add unit test for show interfaces status / intfutil status

Signed-off-by: Wenda Ni <wenni@microsoft.com>

* Add unit test for 'show interfaces status --verbose'

Signed-off-by: Wenda Ni <wenni@microsoft.com>

* Add unit test for 'show subinterfaces status' / 'intfutil status subport'

Signed-off-by: Wenda Ni <wenni@microsoft.com>

* Add unit test for 'show subinterfaces status --verbose'

Signed-off-by: Wenda Ni <wenni@microsoft.com>

* Add unit test for single sub interface status show

Signed-off-by: Wenda Ni <wenni@microsoft.com>

* Add unit test for '--verbose' single sub interface status show

Signed-off-by: Wenda Ni <wenni@microsoft.com>

* Add unit test for showing status of single sub interface in alias naming mode

Signed-off-by: Wenda Ni <wenni@microsoft.com>

* Add unit test for '--verbose' status of single sub interface in alias naming mode

Signed-off-by: Wenda Ni <wenni@microsoft.com>
AidanCopeland pushed a commit to Metaswitch/sonic-buildimage that referenced this pull request Apr 14, 2022
)

* [player] Add more log info when fail response

* [syncd] Send notify view response even when exception happen

* [vs] Add resource limiter

* [vs] Start using resource limiter

* [syncd] Fix vendor sai functions names check

* [syncd] Add apply view remove object sanity checks

* [syncd] Lower NPU switch log to notice

* [syncd] Add simlar best match candidate with most same attributes

* [syncd] Add BreakConfig class

* [syncd] Add break config option to command line

* [syncd] Add comparison logic break before make path

* [syncd] Add break config parser

* [syncd] Add break config size method

* [syncd] Fix command line parser help message

* [syncd] Start using break config parser

* Update aspell

* [tests] Add unittests
stepanblyschak added a commit to stepanblyschak/sonic-buildimage that referenced this pull request Jul 6, 2022
```
8bce8f6 [202111] [select] break the select loop if interrupt_on_signal flag is set (sonic-net#624) (sonic-net#642)
```

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants