[sonic-cfg]: Use vlanid to generate sonic vlan name #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stcheng
reviewed
Jun 13, 2017
| @@ -212,7 +212,8 @@ def parse_dpg(dpg, hname): | |||
| for i, member in enumerate(vmbr_list): | |||
| vmbr_list[i] = port_alias_map[member] | |||
| vlan_attributes = {'name': vintfname, 'members': vmbr_list, 'vlanid': vlanid} | |||
| vlans[vintfname] = vlan_attributes | |||
There was a problem hiding this comment.
what was the vintfname before?
There was a problem hiding this comment.
and could be any string
There was a problem hiding this comment.
maybe it is better to add vlanid in the swss as the vlan name could be some meaningful string? like server v.s. bmc
lguohan
approved these changes
Jun 13, 2017
This was referenced Feb 3, 2018
kcudnik
added a commit
that referenced
this pull request
Dec 5, 2020
[sairedis] Advance sairedis pointer to support cmd zmq flag [meta] Use memcpy instead of cast to prevent strict-aliasing error (#723) [vslib]Add MACsec forward and filters to HostInterfaceInfo (#719) [vslib] Add StateBase function for MACsec (#717) Add support for default zmq synchronous mode flag (#711) [syncd] Code clean (#720) [sairedis] Remove custom bulk fdb methods (#710) [vslib]Add MACsec Filters (#713) [vslib]Add MACsec Forwarder (#714) [vslib]Add MACsec Manager (#715) Add helper functions, findObjects and dumpObject (#716) Code clean refactor (#712) [vslib] Fix CorePortIndexMap log line (#708) [meta] Use custom hash in SaiObjectCollection (#709) Fix LGTM localtime function warnings (#707) [vs] VoQ Switch objects initialization - Local Port OID mapping to System Ports (#703) Code style refactor (#705) [vs] Initialization of VOQ switch objects (#702) [vs] SAI support for VOQ switches - Switch State Initialization (#701) Add MACsec meta methods (#704) [vs] SAI support for VOQ switches (#698) [vs] SAI support for VOQ switches - Core Port Index Map File parser (#700) [vs] SAI support for VoQ switch - Core Port Index Map Container (#699) [syncd][sairedis] Change pub/sub model to push/pull in zmq notification (#695) [syncd] Use lua script to update db when using bulk api (#690) [syncd] Fix bulk api object type for next hop group members (#685) Add FlexCounter for MACsec SA (#684)
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…t#6064) [sairedis] Advance sairedis pointer to support cmd zmq flag [meta] Use memcpy instead of cast to prevent strict-aliasing error (sonic-net#723) [vslib]Add MACsec forward and filters to HostInterfaceInfo (sonic-net#719) [vslib] Add StateBase function for MACsec (sonic-net#717) Add support for default zmq synchronous mode flag (sonic-net#711) [syncd] Code clean (sonic-net#720) [sairedis] Remove custom bulk fdb methods (sonic-net#710) [vslib]Add MACsec Filters (sonic-net#713) [vslib]Add MACsec Forwarder (sonic-net#714) [vslib]Add MACsec Manager (sonic-net#715) Add helper functions, findObjects and dumpObject (sonic-net#716) Code clean refactor (sonic-net#712) [vslib] Fix CorePortIndexMap log line (sonic-net#708) [meta] Use custom hash in SaiObjectCollection (sonic-net#709) Fix LGTM localtime function warnings (sonic-net#707) [vs] VoQ Switch objects initialization - Local Port OID mapping to System Ports (sonic-net#703) Code style refactor (sonic-net#705) [vs] Initialization of VOQ switch objects (sonic-net#702) [vs] SAI support for VOQ switches - Switch State Initialization (sonic-net#701) Add MACsec meta methods (sonic-net#704) [vs] SAI support for VOQ switches (sonic-net#698) [vs] SAI support for VOQ switches - Core Port Index Map File parser (sonic-net#700) [vs] SAI support for VoQ switch - Core Port Index Map Container (sonic-net#699) [syncd][sairedis] Change pub/sub model to push/pull in zmq notification (sonic-net#695) [syncd] Use lua script to update db when using bulk api (sonic-net#690) [syncd] Fix bulk api object type for next hop group members (sonic-net#685) Add FlexCounter for MACsec SA (sonic-net#684)
AidanCopeland
pushed a commit
to Metaswitch/sonic-buildimage
that referenced
this pull request
Apr 14, 2022
…on (sonic-net#695) * [syncd][sairedis] Change pub/sub model to push/pull in zmq notification * [tests] Add zmq push/pull notification unittests * [tests] Reorder libs in makefile * [tests] Update libs dir in Makefile.am
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minigraph vlan name could have any string.
But SONiC requires vlan name to be "Vlan{{id}}".