[Mellanox] Only mount '/var/log/mellanox' folder to syncd docker instead of mounting every sub folder #7830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 9, 2021
qiluo-msft
approved these changes
Jun 9, 2021
|
/azp run |
|
Commenter does not have sufficient privileges for PR 7830 in repo Azure/sonic-buildimage |
liat-grozovik
approved these changes
Jun 18, 2021
liat-grozovik
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Jun 20, 2021
- What I did following the change in PR sonic-net/sonic-buildimage#7830, the folder needs to be created when the first time enables the sniffer function. - How I did it check whether the path to store the sniffer file is existing or not, if not, create it. - How to verify it run command "config platform mlnx sniffer sdk enable", can see sniffer function can be enabled successfully.
|
@qiluo-msft the dependency PR has been merged, would you please help to merge this one? |
qiluo-msft
pushed a commit
that referenced
this pull request
Jul 13, 2021
#### Why I did it Following the discussion in another PR #7708 (comment) , since there will be multi subfolders under **/var/log/mellanox**, so we agreed to only mount this folder and the subfolders will be created afterward on demand. #### How I did it during the syncd docker creation, only mount folder **/var/log/mellanox** #### How to verify it build an Mellanox image and verify the related folder on the host and docker side.
qiluo-msft
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Jul 13, 2021
- What I did following the change in PR sonic-net/sonic-buildimage#7830, the folder needs to be created when the first time enables the sniffer function. - How I did it check whether the path to store the sniffer file is existing or not, if not, create it. - How to verify it run command "config platform mlnx sniffer sdk enable", can see sniffer function can be enabled successfully.
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…-net#7830) #### Why I did it Following the discussion in another PR sonic-net#7708 (comment) , since there will be multi subfolders under **/var/log/mellanox**, so we agreed to only mount this folder and the subfolders will be created afterward on demand. #### How I did it during the syncd docker creation, only mount folder **/var/log/mellanox** #### How to verify it build an Mellanox image and verify the related folder on the host and docker side.
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-utilities
that referenced
this pull request
Aug 10, 2021
- What I did following the change in PR sonic-net/sonic-buildimage#7830, the folder needs to be created when the first time enables the sniffer function. - How I did it check whether the path to store the sniffer file is existing or not, if not, create it. - How to verify it run command "config platform mlnx sniffer sdk enable", can see sniffer function can be enabled successfully.
malletvapid23
added a commit
to malletvapid23/Sonic-Utility
that referenced
this pull request
Aug 3, 2023
- What I did following the change in PR sonic-net/sonic-buildimage#7830, the folder needs to be created when the first time enables the sniffer function. - How I did it check whether the path to store the sniffer file is existing or not, if not, create it. - How to verify it run command "config platform mlnx sniffer sdk enable", can see sniffer function can be enabled successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Following the discussion in another PR #7708 (comment) , since there will be multi subfolders under /var/log/mellanox, so we agreed to only mount this folder and the subfolders will be created afterward on demand.
How I did it
during the syncd docker creation, only mount folder /var/log/mellanox
How to verify it
build an Mellanox image and verify the related folder on the host and docker side.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)