Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DellEMC: S6000, S6100, Z9332f - Add capabilities fields in platform.json #9168

Merged

Conversation

ArunSaravananBalachandran
Copy link
Contributor

@ArunSaravananBalachandran ArunSaravananBalachandran commented Nov 4, 2021

Why I did it

To include capabilities fields in platform.json of DellEMC S6000, S6100, Z9332f platforms.

How I did it

Add the capabilities fields in each platform's respective platform.json.

How to verify it

Ran sonic-mgmt platform api test cases that use capabilities fields and verified that the results are as expected.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

DellEMC: S6000, S6100, Z9332f - Add capabilities fields in platform.json

A picture of a cute animal (not mandatory but encouraged)

@gechiang
Copy link
Collaborator

I see you added new capability fields in the corresponding DELL devices platform.json files.
2 questions:

  1. Can you also add the PR that is making use of this new capability fields in this PR so we can cross reference on how these fields are being accessed and used.
  2. For other Vendors that has not added these capabilities indication in their platform .json files what is the test behavior? Would it be gracefully continue with the old way of test run? Have you tried that?

Thanks!

@ArunSaravananBalachandran
Copy link
Contributor Author

I see you added new capability fields in the corresponding DELL devices platform.json files. 2 questions:

  1. Can you also add the PR that is making use of this new capability fields in this PR so we can cross reference on how these fields are being accessed and used.
  2. For other Vendors that has not added these capabilities indication in their platform .json files what is the test behavior? Would it be gracefully continue with the old way of test run? Have you tried that?

Thanks!

Platform API test cases were updated as part of sonic-net/sonic-mgmt#4332 to make use of capabilities fields in platform.json.
If the capabilities fields are not present, the test cases will fall back to default behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants