[mellanox]: Disable caching for the issu-version file #9235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issu-version file for Mellanox is generated from the Mellanox SDK libraries. The SDK is installed into a Buster docker container, but the issu-version file goes onto the base OS, which is Bullseye. To work around this, the issu-version build rules explicitly copies the issu-version file to target/files/bullseye/ during the Buster build. Because of our build infra, if caching is enabled and a cache is being used, then for issu-version, since it is technically built as part of Buster, then only target/files/buster/issu-version is saved into the cache, and target/files/bullseye/issu-version isn't cached. If this cache gets used, then target/files/bullseye/issu-version is missing, and the final image build fails. This is to work around the current build issue where Mellanox builds are failing. This is so that issu-version is always "built", so that copy is made into the bullseye directory. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
yxieca
approved these changes
Nov 11, 2021
|
mellanox effort: #9234 |
|
I should've checked for opened PRs first. @alexrallen, |
|
@alexrallen , i merged this pr to unblock. |
qiluo-msft
pushed a commit
that referenced
this pull request
Nov 16, 2021
#### Why I did it Mellanox builds were failing intermittently due to the `issue_version` file and MFT package not building correctly in the Azure pipeline environment (both of these packages were patched to build correctly with bullseye running on the host and buster running on the dockers) #### How I did it Fixed two problems: 1. BLDENV is not passed to the Makefiles so the references to this were replaced with correct logic 2. `issue_version` was not defined as a target for bullseye and as such was not cached. Altered the build such that it is defined as a target for bullseye (in the case of buster it builds the file, in the case of bullseye it copies from buster) The previous PR fixing this was reverted as it is no longer necessary for a passing build and was not a long-term fix. #9235 #### How to verify it Build on AZP and verify success.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Saikrishna Arcot sarcot@microsoft.com
Why I did it
This is to work around the current build issue where Mellanox builds are
failing. This is so that issu-version is always "built", so that copy is
made into the bullseye directory.
How I did it
The issu-version file for Mellanox is generated from the Mellanox SDK
libraries. The SDK is installed into a Buster docker container, but the
issu-version file goes onto the base OS, which is Bullseye. To work
around this, the issu-version build rules explicitly copies the
issu-version file to target/files/bullseye/ during the Buster build.
Because of our build infra, if caching is enabled and a cache is being
used, then for issu-version, since it is technically built as part of
Buster, then only target/files/buster/issu-version is saved into the
cache, and target/files/bullseye/issu-version isn't cached. If this
cache gets used, then target/files/bullseye/issu-version is missing, and
the final image build fails.
How to verify it
The CI build for the PR should be sufficient to verify it. If the mellanox build there succeeds, then the regular master branch build should succeed as well.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)